Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RecipeLink component and link to recipes #3005

Merged
merged 27 commits into from
Apr 27, 2023
Merged

Add RecipeLink component and link to recipes #3005

merged 27 commits into from
Apr 27, 2023

Conversation

Jutanium
Copy link
Contributor

@Jutanium Jutanium commented Apr 6, 2023 •
edited
Loading

What kind of changes does this PR include?

  • New or updated content
  • Changes to the docs site code

Description

  • Adds a RecipeLink component that accepts recipe slugs and renders link(s) to the recipe(s)
  • Waiting for @ximenavf92's recipe design to undraft this PR

@netlify
Copy link

netlify bot commented Apr 6, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 6335764
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/644a42a40720a8000842a69f
😎 Deploy Preview https://deploy-preview-3005--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

TheOtterlord
TheOtterlord reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving my 2 cents here. Can't wait to have this component in the docs! The ownership on recipes is amazing

@sarah11918 sarah11918 added site improvement Some thing that improves the website functionality - ask @delucis for help! recipe Best solved by creating a short how-to/example labels Apr 7, 2023
Dan Jutan and others added 2 commits April 8, 2023 08:50
@sarah11918
Copy link
Member

Love you jumping in here, @TheOtterlord!

@Jutanium, let's use this draft PR for adding recipe links to the other existing recipes, then consider this one good (even if it doesn't incorporate any design from Ximena yet.) We can make a separate PR to update the RecipeLinks component itself.

@Jutanium Jutanium marked this pull request as ready for review April 26, 2023 11:08
@Jutanium Jutanium requested review from delucis and sarah11918 April 26, 2023 11:09
sarah11918
sarah11918 reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Jutanium ! I noticed that if there's only one recipe, then everything is all on one line in the component. I think I like that! One small point re: capitalization, but checking through, this all looks good!

Did you want to document using the recipe component in a separate PR?

delucis
delucis requested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for building this out, Dan! Chef Houston is definitely a fun touch to be making an appearance in docs. Made a bunch of suggestions but mostly just cleaning up code and fixing bugs — love the idea in general 🙌

src/content/docs/en/guides/rss.mdx Outdated
@@ -2,7 +2,6 @@
title: Add an RSS feed
description: Let users subscribe to your content by adding an RSS feed to your Astro site.
i18nReady: true
type: recipe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? Didn’t see any discussion of why we’re making this not a recipe (which means it doesn’t show up in “More recipes”).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentional! Thanks so much for catching that

public/houston_chef.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we compress this? I’d drop it in https://squoosh.app/, make it 50% smaller (so it’s ~52px wide), and optimize it.

Dan Jutan and others added 13 commits April 27, 2023 10:30
@delucis
Update src/content/docs/en/core-concepts/endpoints.mdx
d182e90 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/content/docs/en/guides/content.mdx
929f8be 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
6c877be 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
a1107d5 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
adbf222 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
26d6d56 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
a514100 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
5adb95c 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
d2d4080 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
cb0d89c 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/content/docs/en/guides/imports.mdx
ecae7e6 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
5ec6d80 
Co-authored-by: Chris Swithinbank <[email protected]>
@delucis
Update src/components/RecipeLinks.astro
7cf7ffc 
Co-authored-by: Chris Swithinbank <[email protected]>
delucis
delucis approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👨‍🍳🤖

@delucis delucis merged commit 829b663 into main Apr 27, 2023
@delucis delucis deleted the recipes-linking branch April 27, 2023 09:50
@ryuapp ryuapp mentioned this pull request Aug 11, 2023
Merged
@morinokami morinokami mentioned this pull request Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@TheOtterlord TheOtterlord TheOtterlord left review comments

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
recipe Best solved by creating a short how-to/example site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jutanium @sarah11918 @delucis @TheOtterlord