Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config documentation #293

Merged
merged 3 commits into from
Apr 2, 2022
Merged

New config documentation #293

merged 3 commits into from
Apr 2, 2022

Conversation

FredKSchott
Copy link
Member

No description provided.

sarah11918 and others added 2 commits April 1, 2022 09:31
* Changed all config references to mjs

* removed changes here since auto generated

* Update src/pages/en/guides/configuring-astro.md

Co-authored-by: Erika <[email protected]>

Co-authored-by: Erika <[email protected]>
@netlify
Copy link

netlify bot commented Apr 2, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit e84f638
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6248910322850d00084b091a
😎 Deploy Preview https://deploy-preview-293--astro-docs-2.netlify.app/en/reference/configuration-reference
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FredKSchott FredKSchott changed the base branch from main to next April 2, 2022 18:02
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One copy + paste problem

@@ -3,7 +3,7 @@ import fetch from 'node-fetch';
import jsdoc from 'jsdoc-api';

// Fill this in to test a response locally, with fetching.
const STUB = ``;
const STUB = ``; // fs.readFileSync('/PATH/TO/MONOREPO/astro/packages/astro/src/@types/astro.ts', {encoding: 'utf-8'});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just kidding, makes sense to keep this!

@FredKSchott FredKSchott merged commit d0e801a into next Apr 2, 2022
@FredKSchott FredKSchott deleted the new-config-update branch April 2, 2022 18:30
FredKSchott added a commit that referenced this pull request Apr 2, 2022
* Make Astro.request RFC changes (#270)

* Server-side rendering docs (#255)

This documents how to setup and use SSR features in Astro.

* Fix branch

* Update API Reference (#291)

* update API reference

* Update Astro.slots reference

* Update Astro.request and Astro.canonicalURL

* remove Astro.resolve section

Co-authored-by: Matthew Phillips <[email protected]>

* chore: update configuring Astro guide

* New config documentation (#293)

* Changed all astro.config references to .mjs (#283)

* Changed all config references to mjs

* removed changes here since auto generated

* Update src/pages/en/guides/configuring-astro.md

Co-authored-by: Erika <[email protected]>

Co-authored-by: Erika <[email protected]>

* import[dot]meta[dot]env (#286)

* new config

Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Erika <[email protected]>

* update migration guide

* Update config.ts

Co-authored-by: Matthew Phillips <[email protected]>
Co-authored-by: Nate Moore <[email protected]>
Co-authored-by: Nate Moore <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Erika <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants