Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scary warning #2365

Merged
merged 2 commits into from
Jan 12, 2023
Merged

remove scary warning #2365

merged 2 commits into from
Jan 12, 2023

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Jan 12, 2023

Warning is scary, not helpful!

  • astro add is more reliable/familiar to users than at the time of this warning
  • Houston walks a user through the changes to their file
  • the integration READMEs show manual installation and what a properly installed and configured integration should look like, in case a user needs to compare.

Removing the scary warning as a quick fix not to scare off new users. Will revisit this page with more intention in the future.

@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f6de30d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63c08e079a88f8000837748d
😎 Deploy Preview https://deploy-preview-2365--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 12, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks less scary to me!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 merged commit cbe66e9 into main Jan 12, 2023
@sarah11918 sarah11918 deleted the sarah11918-patch-1 branch January 12, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants