Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro.glob(): draft:true warning #1552

Closed
wants to merge 1 commit into from
Closed

Conversation

mrienstra
Copy link
Contributor

There is a warning here: https://docs.astro.build/en/guides/markdown-content/#markdown-drafts

Seems wise to have it here as well: https://docs.astro.build/en/reference/api-reference/#astroglob

... Which is what this PR does. Happy to open an issue instead if it doesn't flow right, I was a little uncertain where exactly to put it.

This warning could instead be in the existing "Markdown Files" subsection, but I feel like it might seem a little random -- that subsection already feels a little random, as it was a bit unclear to me initially why it was there at all. Looks like it was added in #291. Might open an issue about making it a little more clear, like tweaking the title or adding a short intro paragraph about where it's going.

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ee9f64
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6320d739938f74000a967149
😎 Deploy Preview https://deploy-preview-1552--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrienstra
Copy link
Contributor Author

Deploy preview link leading directly to changed section:
https://deploy-preview-1552--astro-docs-2.netlify.app/en/reference/api-reference/#astroglob

@sarah11918
Copy link
Member

sarah11918 commented Sep 14, 2022

Hi @mrienstra!

I'm glad you were able to find the warning about draft posts in the Markdown content page! This is where we are choosing to put that info for now, although we do have plans for making sure that page in particular is reviewed again in the coming weeks to make it even more helpful. We have had a lot of product changes under the hood to our MDX and Markdown features, so there have been some content "add-ons" throughout the site for these topics in particular. Making everything easily discoverable is on our radar!

We would not typically include this kind of content in our Reference section. That is intentionally kept concise, and is more of a lookup kind of resource. We typically do not include things like edge cases, warnings (other than deprecation notices), or troubleshooting advice on these pages. They would quickly get cluttered and it would be more difficult for those trying to quickly look up properties, types etc. We do also have to balance not duplicating material when possible to reduce maintainance costs when features are updated. So, when the material exists in one logical place, we are unlikely to add it again elsewhere.

Thank you for taking the time to help improve the docs, and although I'm closing this PR, I don't think an issue for further exploration is needed. The content is available on the site in an apppropriate place right now, and we will be reorganizing our Markdown/MDX content in the coming weeks. Part of that plan will include highlighting this particular draft feature in a place where people needing that information will find it, including targeted guides for things like enabling draft blog posts, but not adding it to our reference section.

@sarah11918 sarah11918 closed this Sep 14, 2022
@mrienstra
Copy link
Contributor Author

Really appreciate you taking the time to explain the moving pieces & norms, I'll try to soak that up for future reference! 🪴🚰
(no response needed)

@mrienstra mrienstra deleted the patch-1 branch October 5, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants