Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document new CLI flag #11019

Merged
merged 4 commits into from
Feb 26, 2025
Merged

feat: document new CLI flag #11019

merged 4 commits into from
Feb 26, 2025

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Feb 21, 2025

Description (required)

It documents a new CLI flag called --allowed-hosts.

I am not very good at this part, I just referenced the Vite documentation.

For Astro version: 5.4.0. See astro PR #13278

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 77ab41e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67beff11d3998c000869f320
😎 Deploy Preview https://deploy-preview-11019--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 21, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun fact: I just had to configure vite.server.allowedHosts yesterday while working on my site so that Gitpod could display the preview in the browser 😄

Suggesting we accept Armand's edit (mostly word for word) if that sounds good to you, @ematipico !

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Feb 23, 2025
@sarah11918 sarah11918 added this to the 5.4.0 milestone Feb 23, 2025
Co-authored-by: Armand Philippot <[email protected]>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (And, now I'll be able to remove a vite config in my own project... 😄 )

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Feb 25, 2025
@sarah11918 sarah11918 changed the base branch from main to 5.4.0 February 26, 2025 11:46
@sarah11918 sarah11918 merged commit a7b158f into 5.4.0 Feb 26, 2025
9 of 10 checks passed
@sarah11918 sarah11918 deleted the feat/allowed-hosts branch February 26, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants