Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-tw): Update guides/deploy/github.mdx #11011

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

i18n(zh-tw): Update guides/deploy/github.mdx #11011

wants to merge 19 commits into from
+152 −0

Conversation

510208
Copy link

@510208 510208 commented Feb 20, 2025

Description (required)

Update github.mdx (The file which help users deploy there's Astro website to GitHub Pages)

Note

This PR adds a Traditional Chinese guide for deploying an Astro website to GitHub Pages.

Related issues & labels (optional)

  • Closes #
  • Suggested label: i18n

First-time contributor to Astro Docs?

Yes, I love this project very much. But since I am not familiar with Javascript, I cannot provide any useful code.

My Discord username: @samhacker

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Feb 20, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dbbca95
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67c45be8b8f5c400082aa261
😎 Deploy Preview https://deploy-preview-11011--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 20, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
zh-tw/guides/deploy/github.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@vrabe
Copy link
Contributor

vrabe commented Feb 20, 2025

@510208 你好，感謝你的翻譯，我試著檢查看看。

@510208
Copy link
Author

510208 commented Feb 21, 2025

@510208你好，感謝你的翻譯，我試著檢查看看。

OK，等囉~~

@510208 510208 closed this Feb 21, 2025
@510208 510208 reopened this Feb 21, 2025
liruifengv
liruifengv requested changes Feb 22, 2025
View reviewed changes
Copy link
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢你的翻译，不知道我说中文简体你有没有障碍。

对于一些新增的部分，我认为不应该在翻译中添加，如果你认为添加这部分有必要的话，请单独提交一个英文原文修改的PR

vrabe
vrabe suggested changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@vrabe vrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大概是這樣，請不要被數量嚇到

@510208
Copy link
Author

510208 commented Feb 23, 2025

修改完成，請再看看還有沒要改的。

太習慣逐字逐句地翻了，結果有些地方翻譯的不好。因為稍微有參考簡體版本，應該是因為這樣有些用詞才不符合我國的用法吧？

@liruifengv
Copy link
Member

修改完成，請再看看還有沒要改的。

太習慣逐字逐句地翻了，結果有些地方翻譯的不好。因為稍微有參考簡體版本，應該是因為這樣有些用詞才不符合我國的用法吧？

没关系，做的很好。

修改完成的建议，需要点击对应的 resolve，这样 reviewer 就知道你哪个改了

vrabe
vrabe suggested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@vrabe vrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大部分是空格的問題

@ymcheung
Copy link
Contributor

Hi! 乍看有許多地方把主詞全部都翻譯進來了，讀起來很不順：

例如：

這會將你的網站部署在你所指定的自訂網域名稱下...
幫助你部署你的專案。按照下方的說明即可讓你快速將 Astro 網站...

充滿 一個 也是讀起來像是機翻的關鍵，其實這些都可以省略

@510208
Copy link
Author

510208 commented Feb 28, 2025

Hi! 乍看有許多地方把主詞全部都翻譯進來了，讀起來很不順：

例如：

這會將你的網站部署在你所指定的自訂網域名稱下...
幫助你部署你的專案。按照下方的說明即可讓你快速將 Astro 網站...

充滿 一個 也是讀起來像是機翻的關鍵，其實這些都可以省略

嗯，我再改一下

510208 and others added 7 commits March 1, 2025 12:51
@510208
Copy link
Author

510208 commented Mar 1, 2025

已改進，請再看看

vrabe
vrabe suggested changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@vrabe vrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大概就這樣了
第17行跟145行的評論你再看看要不要修改

@510208 510208 requested review from vrabe and liruifengv March 2, 2025 02:19
vrabe
vrabe approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@vrabe vrabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

我覺得可以
看各位有沒有其他意見

@510208 謝謝你的翻譯
如果一切順利，過一段時間就會有maintainer來合併了

liruifengv
liruifengv reviewed Mar 3, 2025
View reviewed changes
src/content/docs/zh-tw/guides/deploy/github.mdx
請確保 `site` 值為以下的其中之一：

- 以你的使用者名稱產生的網址，如：`https://<username>.github.io`
- - 為 [GitHub 組織的不公開頁面](https://docs.github.com/en/enterprise-cloud@latest/pages/getting-started-with-github-pages/changing-the-visibility-of-your-github-pages-site)所產生的亂數網址，如：`https://<random-string>.pages.github.io/`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- - 為 [GitHub 組織的不公開頁面](https://docs.github.com/en/enterprise-cloud@latest/pages/getting-started-with-github-pages/changing-the-visibility-of-your-github-pages-site)所產生的亂數網址，如：`https://<random-string>.pages.github.io/`
- 為 [GitHub 組織的不公開頁面](https://docs.github.com/en/enterprise-cloud@latest/pages/getting-started-with-github-pages/changing-the-visibility-of-your-github-pages-site)所產生的亂數網址，如：`https://<random-string>.pages.github.io/`

这里格式有点问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymcheung ymcheung ymcheung left review comments

@liruifengv liruifengv liruifengv requested changes

@vrabe vrabe vrabe approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@510208 @astrobot-houston @vrabe @liruifengv @ymcheung