-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Loader API: include docs for the built-in loaders #10710
Content Loader API: include docs for the built-in loaders #10710
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Sorry I've been busy the last couple of days and haven't replied, but this is fantastic! I thought I was going to have to get on this myself today or tomorrow. 😄 Was thinking we could look at this on Talking and Doc'ing tomorrow! 🎉 |
Discussed on talking and doc'ing: Content and comprehensiveness are excellent! This is the content we want, just need to incorporate it into the rest of docs fully:
|
I think I made all the updates. I posted again one of my original comments (content has moved) because I'm still not sure this is accurate. Other than that, I think it's ready to you to check the wording when you'll have time @sarah11918! I have reworded some sentences mentioned during T&D but... well, I'm not the expert here. 😄 Note: I had to update a translation to fix a link: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of Oxford commas, but this looks outstanding, Armand! 🥳 Thank you so much for taking this on! 💪
Co-authored-by: Sarah Rainsberger <[email protected]>
Wow, thanks @sarah11918! I wasn't sure my rewording would be enough. 🙌🏽 Do we need a Lunaria directive here? I'm asking because I updated a translation and while I've observed how things have been done in the past, I'm not sure I understand when it's necessary/how it works. |
Yes, @ArmandPhilippot! The zh-cn translation of the page isn't 100% updated with English, so we'd like to keep the outdated status. If it were completely updated, it wouldn't be necessary. Here's the directive you can paste into the commit body during merging:
|
Ok, so basically in these cases I just have to remember to list the paths of the English versions separated by a semicolon (with the prefix of course). Thanks for the explanations, @yanthomasdev! 🫡 (I saw these directives, but didn't look at them more closely before... 😅 ) Well, let's see! 🤞🏽 |
Signed-off-by: Thomas Bonnet <[email protected]>
…#10710 Signed-off-by: Thomas Bonnet <[email protected]>
Description (required)
Updates the Content Loader API page to include a new section for the built-in loaders (
glob
andfile
):generateId
which was missing in the docs,Related issues & labels (optional)