-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ja): Add new reference/content-loader-reference.mdx
translation
#10583
base: main
Are you sure you want to change the base?
i18n(ja): Add new reference/content-loader-reference.mdx
translation
#10583
Conversation
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
reference/content-loader-reference.mdx
reference/content-loader-reference.mdx
translation
Hi. |
I made a single comment but otherwise LGTM! |
Thank you for making a change! LGTM! :) |
0c8358b
to
fb15793
Compare
@dyskinmel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nemuvski Sorry, I missed this one!
This change LGTM
67ee086
to
af483fc
Compare
@dyskinmel Could you please review this pull request? Thank you in advance. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<p> | ||
|
||
**Type:** <code>(fileName: string, options?: FileOptions) => <a href="#the-loader-object">Loader</a></code><br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing a CI:Check Links error, but since it's a sample code, it shouldn't be an issue.
Is this a warning that can be safely ignored?
https://github.com/withastro/docs/actions/runs/13555345834/job/37888338785?pr=10583
The linked page does not contain a fragment with the name "#the-loader-object".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not exactly sample code, that's an inline code block that links to a part of the same page. In this case, you should replace #the-loader-object
with #loaderオブジェクト
since its the slug for the heading in question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll make the corrections.
|
||
## ローダーとは? | ||
|
||
Astroのローダーを使用すると、[コンテンツコレクション](/ja/guides/content-collections/)にデータをロードでき、ページやコンポーネントで使用できます。[ビルトインの`glob()`および`file()`ローダー](/en/guides/content-collections/#built-in-loaders)はファイルシステムからコンテンツをロードするために使用され、他のソースからコンテンツをロードするために独自のローダーを作成することもできます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing the following CI:Check Links error.
Expected link path to start with "/ja/", but found "/en/".
Since the Japanese translation of the linked page is not up to date and the fragment has become invalid, I used /en
.
Is this a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it expects all links to be for that page to be prefixed with the correct language, what you could do is to translate the other page in another PR, get it reviewed and merge, and then update it here, or, you can remove the link and add a TODO comment asking to add the link back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I'll change the link to use the "ja" prefix and leave a TODO comment.
@yanthomasdev I have something I’d like to discuss. It’s about the comments I left on this pull request. Best regards, |
ecef3b9
to
399926b
Compare
I have fixed the warnings detected by Link Checks in my commit. Could you please review 399926b, |
Description
This PR adds a Japanese translation to
reference/content-loader-reference.mdx
.The original English version: https://docs.astro.build/en/reference/content-loader-reference/ (on github)