Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ja): Add new reference/content-loader-reference.mdx translation #10583

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nemuvski
Copy link

@nemuvski nemuvski commented Jan 2, 2025

Description

This PR adds a Japanese translation to reference/content-loader-reference.mdx.

The original English version: https://docs.astro.build/en/reference/content-loader-reference/ (on github)

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 2, 2025
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 2, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ja/reference/content-loader-reference.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e933e4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67c311bcc541ad00085ce9ae
😎 Deploy Preview https://deploy-preview-10583--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nemuvski nemuvski changed the title i18n(ja): create reference/content-loader-reference.mdx i18n(ja): Add new reference/content-loader-reference.mdx translation Jan 16, 2025
@nemuvski
Copy link
Author

Hi.
Could you please review this pull request?
Thank you in advance.

@dyskinmel
Copy link
Contributor

I made a single comment but otherwise LGTM!

@nemuvski nemuvski requested a review from dyskinmel January 23, 2025 08:54
@dyskinmel
Copy link
Contributor

Thank you for making a change! LGTM! :)

@nemuvski nemuvski force-pushed the i18n-ja-content-loader-reference branch from 0c8358b to fb15793 Compare January 25, 2025 06:06
@nemuvski
Copy link
Author

@dyskinmel
One of the links was incorrect, so I have fixed it. fb15793
I apologize for the repeated requests, but could you please review it again?

@nemuvski nemuvski requested a review from dyskinmel January 25, 2025 06:23
Copy link
Contributor

@dyskinmel dyskinmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemuvski Sorry, I missed this one!
This change LGTM

@nemuvski nemuvski force-pushed the i18n-ja-content-loader-reference branch from 67ee086 to af483fc Compare February 25, 2025 13:39
@nemuvski nemuvski requested a review from dyskinmel February 25, 2025 13:51
@nemuvski
Copy link
Author

@dyskinmel
Thanks for your reviewing!
While I was submitting the PR, the English version was updated (Built-in loaders section), so I committed the changes. ✨

Could you please review this pull request? Thank you in advance. 🙏

Copy link
Contributor

@dyskinmel dyskinmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemuvski I have reviewed the updates made in commit 9807f1a. LGTM!


<p>

**Type:** <code>(fileName: string, options?: FileOptions) => <a href="#the-loader-object">Loader</a></code><br />
Copy link
Author

@nemuvski nemuvski Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing a CI:Check Links error, but since it's a sample code, it shouldn't be an issue.
Is this a warning that can be safely ignored?

https://github.com/withastro/docs/actions/runs/13555345834/job/37888338785?pr=10583

The linked page does not contain a fragment with the name "#the-loader-object".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not exactly sample code, that's an inline code block that links to a part of the same page. In this case, you should replace #the-loader-object with #loaderオブジェクト since its the slug for the heading in question.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll make the corrections.


## ローダーとは?

Astroのローダーを使用すると、[コンテンツコレクション](/ja/guides/content-collections/)にデータをロードでき、ページやコンポーネントで使用できます。[ビルトインの`glob()`および`file()`ローダー](/en/guides/content-collections/#built-in-loaders)はファイルシステムからコンテンツをロードするために使用され、他のソースからコンテンツをロードするために独自のローダーを作成することもできます。
Copy link
Author

@nemuvski nemuvski Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing the following CI:Check Links error.

Expected link path to start with "/ja/", but found "/en/".

Since the Japanese translation of the linked page is not up to date and the fragment has become invalid, I used /en.
Is this a problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it expects all links to be for that page to be prefixed with the correct language, what you could do is to translate the other page in another PR, get it reviewed and merge, and then update it here, or, you can remove the link and add a TODO comment asking to add the link back.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I'll change the link to use the "ja" prefix and leave a TODO comment.

@nemuvski
Copy link
Author

@yanthomasdev
Hello,

I have something I’d like to discuss. It’s about the comments I left on this pull request.
Would you mind reviewing them? 🙏

Best regards,

@nemuvski nemuvski force-pushed the i18n-ja-content-loader-reference branch from ecef3b9 to 399926b Compare March 1, 2025 05:42
@nemuvski
Copy link
Author

nemuvski commented Mar 1, 2025

I have fixed the warnings detected by Link Checks in my commit. Could you please review 399926b,
4e933e4 ?
@dyskinmel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants