Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested pagination example code broken? #4440

Closed
tadyjp opened this issue Aug 30, 2023 · 2 comments · Fixed by #4476
Closed

Nested pagination example code broken? #4440

tadyjp opened this issue Aug 30, 2023 · 2 comments · Fixed by #4476
Labels
code snippet update Updates a code sample: typo, outdated code etc. good first issue Good for newcomers

Comments

@tadyjp
Copy link
Contributor

tadyjp commented Aug 30, 2023

In Nested Pagination example code, should allTags.map be allTags.flatMap?
https://docs.astro.build/en/core-concepts/routing/#nested-pagination

related: #3756 (comment)
@ElianCodes
Copy link
Member

You are correct indeed! Are you willing to open up a PR and fix this yourself?

@ElianCodes ElianCodes added code snippet update Updates a code sample: typo, outdated code etc. good first issue Good for newcomers labels Aug 30, 2023
@tadyjp
Copy link
Contributor Author

tadyjp commented Aug 31, 2023

@ElianCodes Yes, I will try to fix it myself within the next few days!

tadyjp added a commit to tadyjp/docs that referenced this issue Aug 31, 2023
@tadyjp
return flaMap by getStaticPaths
d54df3f 
withastro#4440
@tadyjp tadyjp mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code snippet update Updates a code sample: typo, outdated code etc. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Manually flattening return value of getStaticPaths with paginate tadyjp/docs
2 participants
@tadyjp @ElianCodes