Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an IIFE to scope define:vars scripts #599

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Use an IIFE to scope define:vars scripts #599

merged 2 commits into from
Oct 28, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Tests updated.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: b225f42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that fix is a heck of a lot cleaner than I expected given the bug it fixes!

The fix and tests look good to me, leaving it open for Nate's approval though in case there are compiler edge cases hidden here

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried about import/export but we're already skipping module scripts, so this looks good!

@matthewp matthewp merged commit 73a2b69 into main Oct 28, 2022
@matthewp matthewp deleted the define-vars-iife branch October 28, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants