chore: add regression test for withastro/compiler#950 #9872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
MoustaphaDev
changed the title
MoustaphaDev
force-pushed
the
mk/slot-loop-test
branch
from
fba5432 to
33612d5
Compare
MoustaphaDev
commented
Jan 30, 2024
| @@ -114,7 +114,7 @@ | |||
| "test:e2e:match": "playwright test -g" | |||
| }, | |||
| "dependencies": { | |||
| "@astrojs/compiler": "^2.5.0", | |||
| "@astrojs/compiler": "0.0.0-mk-slot-expr-fix-20240130083013", | |||
There was a problem hiding this comment.
We normally don't need to update the compiler version here, this was changed just to publicly validate the compiler bug fix.
MoustaphaDev
changed the title
MoustaphaDev
changed the title
MoustaphaDev
changed the title
|
Closing as we're rolling back the feature to rework it, it was causing too many regressions in with slots |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Depends on withastro/compiler#952, should be merged only after the next compiler release
Adds a regression test for withastro/compiler#950
Testing
Ensure that all the slots are rendered
Docs
N/A only tests were added