-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dot files not being copied over on non-root builds (#9740) #9741
Fix dot files not being copied over on non-root builds (#9740) #9741
Conversation
When running `astro build` outside of where the astro files are, dotfiles are not copied over because the `includeDotfiles` parameter is not passed in.
🦋 Changeset detectedLatest commit: e1e5b9c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this earlier. Looks great to me!
Thanks for fixing it 💜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think with this change we might always be copying dotfiles and can probably remove the third argument? No need to take care of that in this PR, though.
…de of astro folder Needed because nx runs in the root folder outside of `ag-charts-website`, and there is a bug in astro that doesn't copy dot files over in these instances. Can remove this, when withastro/astro#9741 is merged
Changes
Fixes #9740
When running
astro build
outside of where the astro files are, dotfiles are not copied over because theincludeDotfiles
parameter is not passed in. This PR adds atrue
includeDotfiles
value tocopyFiles
to fix this.Testing
Check out this PR locally
Download astro bug example https://stackblitz.com/edit/github-es2mdg-tnkbfm?file=README.md
Check bug
Not sure if this requires an e2e test, but if so, please point me in the direction of an example of how one is set up.
Docs
Fixes a bug with build, so shouldn't affect any of the docs