Fix image metadata generation #7510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed url started with /@astroimage
🦋 Changeset detectedLatest commit: 2fd73e3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
Merged
matthewp
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Fix problem where image metadata generation throwed error when provided url started with /@astroimage * Remove unnecessary changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #7442
ImageandPicturecomponentsmetadatafunction is called with/@astroimage/...src after transformations are done. ButfileURLToPathcannot accept this kind of url and it throws an error.Testing
Manually, here are the results.
Before:
After:
Docs
Api didn't change so I don't think there is a need to update the docs.