Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro:assets): inject /_image endpoint with prerendered=false on serverLikeOutput #7423

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

bmenant
Copy link
Contributor

@bmenant bmenant commented Jun 19, 2023

Fixes #7415

Changes

  • Add a boolean property to set prerender value when injectingRoutes
  • Effectively set /_image endpoint with prerender: false (was added as a prerendered asset/route before)

Testing

Again, I would love very much to add a couple of tests around manifest and/or routing settings, but could find relevant test suites so far. Guidance would be much appreciated.

Docs

No change relevant to user.

@bmenant bmenant requested a review from a team as a code owner June 19, 2023 17:58
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

🦋 Changeset detected

Latest commit: 44bdcc1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 19, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@bluwy bluwy merged commit 33cdc86 into withastro:main Jun 22, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images (astro:assets) are not rendered (got 404) on SSR pages on hybrid build with node adapter
2 participants