Treeshake exported client components that are not imported #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 887fae4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
reviewed
Mar 13, 2023
natemoo-re
approved these changes
Mar 13, 2023
Merged
|
Is this not merged into the main branch? I updated 2.1.3 and still report an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #6467
When a hydrated or
client:onlycomponent is passed to the client build, only build those that are imported. e.g.import { Foo } from './ManyComponents.jsx', the bundled entry should only exportFooand not other unused components.This PR changes our client component collection logic to also track exports names imported. A custom Vite plugin is used to proxy entries to something like
export { Foo } from '/resolved/path/ManyComponents.jsx', so that we treeshake the unused components.Testing
Added a bundling test to make sure unused components are treeshaken.
Docs
n/a. Bug fix.