-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated according to new configuration #5478
Conversation
🦋 Changeset detectedLatest commit: 8f75400 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@nemo0 can you update the other readmes? |
Hey @matthewp . Sure. I would love to update the readmes. |
Astro imports the `defineConfig` function from `astro/config`. The `integrations` key needs to be passed into the `defineConfig` function, but it is not shown in the README. Updated the README according to the CLI example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @natemoo-re!
Found the last one in the svelte integration readme line 102 |
Just a heads up that because this PR was opened so long ago, one of its original pages was outdated. Since it was accepted into the main branch for its minor changes to the config example, it brought back with it the "old" page. And, this merging was done after I had looked at the changes and approved. I'm not sure how we avoid this from happening again, but maybe when addressing a super-old PR we make sure the author first updates their branch? cc @natemoo-re |
Astro imports the
defineConfig
function fromastro/config
. Theintegrations
key needs to be passed into thedefineConfig
function, but it is not shown in the README. Updated the README according to the CLI example.Changes
astro.config.mjs
example shown in the README is changedTesting
Docs