Allow overriding build vite config options #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d61a50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
tony-sull
approved these changes
May 17, 2022
| @@ -201,7 +201,7 @@ async function clientBuild( | |||
| // TODO: use vite.mergeConfig() here? | |||
| info(opts.logging, null, `\n${bgGreen(black(' building client '))}`); | |||
|
|
|||
| const viteBuildConfig = { | |||
| const viteBuildConfig = vite.mergeConfig({ | |||
| logLevel: 'info', | |||
| mode: 'production', | |||
| css: viteConfig.css, | |||
There was a problem hiding this comment.
probably not important, but can css, server, and base be removed here since they'll get merged in from viteConfig?
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Allow overriding build vite config options * Adds a changeset * Test svelte * Move plugins down * Assign after for the client too * Spread output options on manually * Remove .only
|
How to disable css hashing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
viteconfig to override options that are used for SSR.Testing
Docs
N/A