Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: add prerelease warning #2758

Merged
merged 10 commits into from
Mar 10, 2022
Merged

CLI: add prerelease warning #2758

merged 10 commits into from
Mar 10, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Mar 10, 2022 •
edited
Loading

Changes

  • Adds a warning on dev startup when Astro is in a pre-release mode.

Screen Shot 2022-03-10 at 4 58 12 PM

Testing

Tested manually, we need snapshot tests to properly cover this

Docs

N/A but added Netlify redirect for https://astro.build/issues

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 358822a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 10, 2022
@natemoo-re natemoo-re mentioned this pull request Mar 10, 2022
Closed
@FredKSchott
Copy link
Member

FredKSchott commented Mar 10, 2022 •
edited
Loading

Feedback:

  • This is gorgeous!
  • re prerelease I like this, but wish the second message ("Undocumented changes may happen at any time") was less scary or maybe didn't exist at all. Could it instead say something productive like "Leave feedback and report bugs at astro.build/error" ?
  • re update available This feels like one of those classic "oh this sounds cool but lets think it through a bit more":
    • This means that startup will hang out an API call every time? I'm at a coffeeshop now and I can just imagine how frustrating that would be.
    • If I'm not an older version for a reason, I could see this also being annoying. the most popular npm package for handling this for you will give you a max of 1 warning a day (maybe week?) for that reason.
    • I'd really love to pull this out of this PR for now, we have enough moving parts to get v0.24.0 out and I'd rather not add more.

@natemoo-re natemoo-re changed the title CLI: add prerelease and outdated warnings CLI: add prerelease warning Mar 10, 2022
FredKSchott
FredKSchott approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once whatever URL you use actually exists!

@natemoo-re natemoo-re merged commit 499fb6a into main Mar 10, 2022
@natemoo-re natemoo-re deleted the feat/cli-update branch March 10, 2022 23:25
This was referenced Mar 10, 2022
Merged
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@natemoo-re
CLI: add prerelease warning (withastro#2758)
92eb99e 
* feat(cli): add prerelease and outdated warnings

* refactor: cleanup getLatestVersion code

* refactor: simplify isPrerelease logic

* chore: add changeset

* fix: do not require devStart for preview

* refactor: extract prerelase/outdated into own templates

* feat: remove upgrade warning

* feat: make prerelease less scary

* chore: update prerelease wording

* chore: update feedback copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemoo-re @FredKSchott