Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and run format command #2736

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix and run format command #2736

merged 1 commit into from
Mar 8, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Mar 8, 2022 •
edited
Loading

Changes

  • format CI seems to be failing, and yarn format makes a lot of changes to the existing repo
  • fixes CI, updates our ignore file, re-runs format, and then commits it all

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ef2f78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) test 🚨 action Modifies GitHub Actions labels Mar 8, 2022
@matthewp
Copy link
Contributor

matthewp commented Mar 8, 2022

Dupe of #2735?

natemoo-re
natemoo-re approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Possible dupe of #2735 ?

@FredKSchott FredKSchott mentioned this pull request Mar 8, 2022
Closed
@FredKSchott FredKSchott merged commit 240d88a into main Mar 8, 2022
@FredKSchott FredKSchott deleted the fix-format branch March 8, 2022 23:20
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
fix format (withastro#2736)
c614c8d
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
fix format (withastro#2736)
2281a41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredKSchott @matthewp @natemoo-re