Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass astro version as argument to integration hook astro:config... #13116

Conversation

feelixe
Copy link

@feelixe feelixe commented Jan 31, 2025

Changes

  • Pass constant ASTRO_VERSION as argument to integration hook astro:config:setup.

Testing

None added yet.

Docs

Argument needs to be added to docs page Integration API

/cc @withastro/maintainers-docs for feedback!

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 00c2908

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #13116 will not alter performance

Comparing feelixe:feat/pass-astro-version-to-integrations (00c2908) with main (2a85bd7)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off! A few comments:

  1. I think the property should be named version
  2. I'm not sure it's worth adding some tests since it will default to development
  3. It needs a minor changeset
  4. It needs a docs PR
  5. I think to make this feature useful, we'll need a utility in https://astro-integration-kit.netlify.app/

@feelixe
Copy link
Author

feelixe commented Feb 3, 2025

Thanks for kicking this off! A few comments:

  1. I think the property should be named version
  2. I'm not sure it's worth adding some tests since it will default to development
  3. It needs a minor changeset
  4. It needs a docs PR
  5. I think to make this feature useful, we'll need a utility in https://astro-integration-kit.netlify.app/

thank you, ill get on that

@florian-lefebvre florian-lefebvre self-assigned this Feb 3, 2025
@florian-lefebvre
Copy link
Member

Do not invest too much time into it just yet, we are discussing it and think the API could take another shape (eg. exporting a constant from a new entrypoint)

@florian-lefebvre
Copy link
Member

Thanks for the initative! Closing, more details on the roadmap discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants