-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: content types sync in dev #11716
Conversation
🦋 Changeset detectedLatest commit: d93fbc9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -124,6 +124,14 @@ export async function syncInternal({ | |||
}); | |||
await contentLayer.sync(); | |||
settings.timer.end('Sync content layer'); | |||
} else if (fs.existsSync(getContentPaths(settings.config, fs).contentDir.href)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work on Windows? Using href
might be unsafe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was required to make some tests pass (see first commit). I manually tested it and it seems to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit worried by the href
, but if it works and tests pass, who I am to be worried.
Changes
Testing
Should pass
Docs
N/A