Prevent externalized adapters from breaking build #11709

matthewp · 2024-08-14T16:22:00Z

Changes

Closes New build error - Astro 4.13.4 #11700
A different approach than fix: server islands regression in bundling #11702, makes a virtual module that can be imported even if the adapter is external.

Testing

Preview release

Docs

N/A, bug fix

changeset-bot · 2024-08-14T16:22:05Z

🦋 Changeset detected

Latest commit: b6be99a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

matthewp · 2024-08-14T16:25:45Z

!preview-si-crypto-reg

github-actions · 2024-08-14T16:25:57Z

Invalid command. Expected: "/preview "

matthewp · 2024-08-14T16:27:37Z

!preview si-crypto-reg

ascorbic · 2024-08-14T16:29:33Z

packages/astro/src/core/build/plugins/plugin-ssr.ts

@@ -49,6 +52,9 @@ function vitePluginSSR(
 			if (id === SSR_VIRTUAL_MODULE_ID) {
 				return RESOLVED_SSR_VIRTUAL_MODULE_ID;
 			}
+			if (id === ADAPTER_VIRTUAL_MODULE_ID) {
+				return RESOLVED_ADAPTER_VIRTUAL_MODULE_ID;


Would it work to just return adapter.serverEntrypoint here?

Oh, interesting idea, let me try.

Doesn't work, rollup complains about it being external again.

github-actions · 2024-08-14T16:29:35Z

Snapshots have been released for the following packages:

astro@experimental--si-crypto-reg
@astrojs/db@experimental--si-crypto-reg
create-astro@experimental--si-crypto-reg
@astrojs/upgrade@experimental--si-crypto-reg
@astrojs/web-vitals@experimental--si-crypto-reg

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--si-crypto-reg tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info astro
🦋  info npm info @astrojs/prism
🦋  info npm info @astrojs/rss
🦋  info npm info create-astro
🦋  info npm info @astrojs/db
🦋  info npm info @astrojs/alpinejs
🦋  info npm info @astrojs/lit
🦋  info npm info @astrojs/markdoc
🦋  info npm info @astrojs/mdx
🦋  info npm info @astrojs/node
🦋  info npm info @astrojs/partytown
🦋  info npm info @astrojs/preact
🦋  info npm info @astrojs/react
🦋  info npm info @astrojs/sitemap
🦋  info npm info @astrojs/solid-js
🦋  info npm info @astrojs/svelte
🦋  info npm info @astrojs/tailwind
🦋  info npm info @astrojs/vercel
🦋  info npm info @astrojs/vue
🦋  info npm info @astrojs/web-vitals
🦋  info npm info @astrojs/internal-helpers
🦋  info npm info @astrojs/markdown-remark
🦋  info npm info @astrojs/studio
🦋  info npm info @astrojs/telemetry
🦋  info npm info @astrojs/underscore-redirects
🦋  info npm info @astrojs/upgrade
🦋  info astro is being published because our local version (0.0.0-si-crypto-reg-20240814162819) has not been published on npm
🦋  warn @astrojs/prism is not being published because version 3.1.0 is already published on npm
🦋  warn @astrojs/rss is not being published because version 4.0.7 is already published on npm
🦋  info create-astro is being published because our local version (0.0.0-si-crypto-reg-20240814162819) has not been published on npm
🦋  info @astrojs/db is being published because our local version (0.0.0-si-crypto-reg-20240814162819) has not been published on npm
🦋  warn @astrojs/alpinejs is not being published because version 0.4.0 is already published on npm
🦋  warn @astrojs/lit is not being published because version 4.3.0 is already published on npm
🦋  warn @astrojs/markdoc is not being published because version 0.11.3 is already published on npm
🦋  warn @astrojs/mdx is not being published because version 3.1.3 is already published on npm
🦋  warn @astrojs/node is not being published because version 8.3.3 is already published on npm
🦋  warn @astrojs/partytown is not being published because version 2.1.1 is already published on npm
🦋  warn @astrojs/preact is not being published because version 3.5.1 is already published on npm
🦋  warn @astrojs/react is not being published because version 3.6.2 is already published on npm
🦋  warn @astrojs/sitemap is not being published because version 3.1.6 is already published on npm
🦋  warn @astrojs/solid-js is not being published because version 4.4.1 is already published on npm
🦋  warn @astrojs/svelte is not being published because version 5.7.0 is already published on npm
🦋  warn @astrojs/tailwind is not being published because version 5.1.0 is already published on npm
🦋  warn @astrojs/vercel is not being published because version 7.7.2 is already published on npm
🦋  warn @astrojs/vue is not being published because version 4.5.0 is already published on npm
🦋  info @astrojs/web-vitals is being published because our local version (0.0.0-si-crypto-reg-20240814162819) has not been published on npm
🦋  warn @astrojs/internal-helpers is not being published because version 0.4.1 is already published on npm
🦋  warn @astrojs/markdown-remark is not being published because version 5.2.0 is already published on npm
🦋  warn @astrojs/studio is not being published because version 0.1.1 is already published on npm
🦋  warn @astrojs/telemetry is not being published because version 3.1.0 is already published on npm
🦋  warn @astrojs/underscore-redirects is not being published because version 0.3.4 is already published on npm
🦋  info @astrojs/upgrade is being published because our local version (0.0.0-si-crypto-reg-20240814162819) has not been published on npm
🦋  info Publishing "astro" at "0.0.0-si-crypto-reg-20240814162819"
🦋  info Publishing "create-astro" at "0.0.0-si-crypto-reg-20240814162819"
🦋  info Publishing "@astrojs/db" at "0.0.0-si-crypto-reg-20240814162819"
🦋  info Publishing "@astrojs/web-vitals" at "0.0.0-si-crypto-reg-20240814162819"
🦋  info Publishing "@astrojs/upgrade" at "0.0.0-si-crypto-reg-20240814162819"
🦋  success packages published successfully:
🦋  [email protected]
🦋  [email protected]
🦋  @astrojs/[email protected]
🦋  @astrojs/[email protected]
🦋  @astrojs/[email protected]
🦋  Creating git tags...
🦋  New tag:  [email protected]
🦋  New tag:  [email protected]
🦋  New tag:  @astrojs/[email protected]
🦋  New tag:  @astrojs/[email protected]
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/astro/astro
> turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*"

• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/db, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/studio, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/upgrade, @astrojs/vercel, @astrojs/vue, @astrojs/web-vitals, @benchmark/timer, astro, create-astro
• Running build in 29 packages
• Remote caching enabled
::group::@astrojs/prism:build
cache miss, executing cabe34bc4b7db5a0

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-prism
> astro-scripts build "src/**/*.ts" && tsc -p ./tsconfig.json

::endgroup::
::group::@astrojs/internal-helpers:build
cache miss, executing 9f3ecb57b29724ba

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/internal-helpers
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json


> @astrojs/[email protected] postbuild /home/runner/work/astro/astro/packages/internal-helpers
> astro-scripts copy "src/**/*.js"

::endgroup::
::group::@astrojs/upgrade:build
cache miss, executing c8f3b9ab51eda68d

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/upgrade
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::@astrojs/telemetry:build
cache miss, executing ad517c6b725d6de3

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/telemetry
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::create-astro:build
cache miss, executing 1174514903bef969

> [email protected] build /home/runner/work/astro/astro/packages/create-astro
> astro-scripts build "src/index.ts" --bundle && tsc

::endgroup::
::group::@astrojs/markdown-remark:build
cache miss, executing 7fee0a734ee0a53a

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/markdown/remark
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json


> @astrojs/[email protected] postbuild /home/runner/work/astro/astro/packages/markdown/remark
> astro-scripts copy "src/**/*.js"

::endgroup::
::group::astro:build
cache miss, executing 0fa163181a688ce2

> [email protected] build /home/runner/work/astro/astro/packages/astro
> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild


> [email protected] prebuild /home/runner/work/astro/astro/packages/astro
> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts"


> [email protected] postbuild /home/runner/work/astro/astro/packages/astro
> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm"

::endgroup::
::group::@astrojs/alpinejs:build
cache miss, executing 8a8e1e41f318b192

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@benchmark/timer:build
cache miss, executing e0bdec2f2c368bfb

> @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/timer
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/partytown:build
cache miss, executing b3d12c8d6bfc2131

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/rss:build
cache miss, executing c9f6ae45b656e670

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/tailwind:build
cache miss, executing 1b903076b9bf8643

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/node:build
cache miss, executing fb95a6cf8ab17096

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/node
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vercel:build
cache miss, executing 087f9805ef0a6c1c

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vercel
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/solid-js:build
cache miss, executing 969aa629ea2f0f99

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/mdx:build
cache miss, executing 03a5285d2984f831

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/vue:build
cache miss, executing d56d92c983222ef1

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/studio:build
cache miss, executing d624d5d744f33f42

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/studio
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/underscore-redirects:build
cache miss, executing b68b904637e381eb

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json


> @astrojs/[email protected] postbuild /home/runner/work/astro/astro/packages/underscore-redirects
> astro-scripts copy "src/**/*.js"

::endgroup::
::group::@astrojs/react:build
cache miss, executing 2c2d80eb100849fb

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/markdoc:build
cache miss, executing c20a730576a8ab32

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/markdoc
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/lit:build
cache miss, executing d7a3553324131a4b

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/lit
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/svelte:build
cache miss, executing dae9c60b1ace0fca

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte
> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc

::endgroup::
::group::@astrojs/preact:build
cache miss, executing 8aed97a6a2334d39

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/sitemap:build
cache miss, executing 5193f831168ef0a5

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::
::group::@astrojs/db:build
cache miss, executing 83072bf257dcf2a3

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/db
> astro-scripts build "src/**/*.ts" && tsc && pnpm types:virtual


> @astrojs/[email protected] types:virtual /home/runner/work/astro/astro/packages/db
> tsc -p ./tsconfig.virtual.json

::endgroup::
::group::@astrojs/web-vitals:build
cache miss, executing 73932fad648a7535

> @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/web-vitals
> astro-scripts build "src/**/*.ts" && tsc

::endgroup::

 Tasks:    27 successful, 27 total
Cached:    0 cached, 27 total
  Time:    57.542s

matthewp · 2024-08-14T17:02:23Z

Confirmed this fixes the reproduction.

Princesseuh

don't know everything here but looks fine to me!

Prevent externalized adapters from breaking build

5461eac

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 14, 2024

Add a changeset

bdb0c6a

ascorbic reviewed Aug 14, 2024

View reviewed changes

matthewp added 2 commits August 14, 2024 12:54

Implement in both types of build plugins

edff26f

linting :(

b6be99a

matthewp mentioned this pull request Aug 14, 2024

fix: server islands regression in bundling #11702

Closed

Princesseuh approved these changes Aug 14, 2024

View reviewed changes

matthewp merged commit 3d8ae76 into main Aug 14, 2024
13 checks passed

matthewp deleted the wrap-adapter branch August 14, 2024 17:30

astrobot-houston mentioned this pull request Aug 14, 2024

[ci] release #11699

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent externalized adapters from breaking build #11709

Prevent externalized adapters from breaking build #11709

matthewp commented Aug 14, 2024

changeset-bot bot commented Aug 14, 2024 •

edited

Loading

matthewp commented Aug 14, 2024

github-actions bot commented Aug 14, 2024

matthewp commented Aug 14, 2024

ascorbic Aug 14, 2024

matthewp Aug 14, 2024

matthewp Aug 14, 2024

github-actions bot commented Aug 14, 2024

matthewp commented Aug 14, 2024

Princesseuh left a comment

Prevent externalized adapters from breaking build #11709

Prevent externalized adapters from breaking build #11709

Conversation

matthewp commented Aug 14, 2024

Changes

Testing

Docs

changeset-bot bot commented Aug 14, 2024 • edited Loading

🦋 Changeset detected

matthewp commented Aug 14, 2024

github-actions bot commented Aug 14, 2024

matthewp commented Aug 14, 2024

ascorbic Aug 14, 2024

Choose a reason for hiding this comment

matthewp Aug 14, 2024

Choose a reason for hiding this comment

matthewp Aug 14, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 14, 2024

matthewp commented Aug 14, 2024

Princesseuh left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Aug 14, 2024 •

edited

Loading