Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Content Layer loader #11334
feat: add Content Layer loader #11334
Changes from 11 commits
aa1db49
a7639e3
63a23d2
624c377
d67ee7e
631f3d2
4b7f8f7
14330f7
b3b8dd4
04d09f0
c932fb8
941c4be
f997ca5
92c3312
e0bd9cd
5cd5670
6ca356a
3fcdc59
14322d4
3e21f03
8d310af
0a89f15
51fcda3
9de133f
6bb89bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This operation could fail (invalid JSON) and we should handle it. Or, maybe call the function
tryLoad
, or at least documenting that the operation could fail (or should not fail).Essentially, how do we handle a
load
that couldn't load the data due to an error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could document this function, and explain how to use it and when/where.