fix(cloudflare): base strip logic

Fixes the strip logic for _config.base. Apparently the negative indexing is a feature of the deprecated substr, not substring.
withastro · Mar 15, 2023 · ac73b1c · ac73b1c
1 parent 22955b8
commit ac73b1c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/early-kangaroos-invent.md b/.changeset/early-kangaroos-invent.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/cloudflare': patch
+---
+
+fix `config.base` trimming logic for cloudflare integration `_routes.json` generation
diff --git a/packages/integrations/cloudflare/src/index.ts b/packages/integrations/cloudflare/src/index.ts
@@ -156,7 +156,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
 						let pagePath = prependForwardSlash(page.pathname);
 						if (_config.base !== '/') {
 							const base = _config.base.endsWith('/')
-								? _config.base.substring(0, -1)
+								? _config.base.substring(0, _config.base.length - 1)
 								: _config.base;
 							pagePath = `${base}${pagePath}`;
 						}