Define toStringTag another way (#4855)

* Define toStringTag another way * Adding a changeset
withastro · Sep 23, 2022 · 49ca9e1 · 49ca9e1
1 parent f4edba8
commit 49ca9e1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/.changeset/fluffy-doors-vanish.md b/.changeset/fluffy-doors-vanish.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix TS errors when not using skipLibCheck
diff --git a/packages/astro/src/runtime/server/escape.ts b/packages/astro/src/runtime/server/escape.ts
@@ -3,12 +3,15 @@ import { escape } from 'html-escaper';
 // Leverage the battle-tested `html-escaper` npm package.
 export const escapeHTML = escape;
 
-export class HTMLBytes extends Uint8Array {
-	// @ts-ignore
-	get [Symbol.toStringTag]() {
+export class HTMLBytes extends Uint8Array {}
+
+// TypeScript won't let us define this in the class body so have to do it
+// this way. Boo.
+Object.defineProperty(HTMLBytes.prototype, Symbol.toStringTag, {
+	get() {
 		return 'HTMLBytes';
 	}
-}
+});
 
 /**
  * A "blessed" extension of String that tells Astro that the string