Fix warning

wisnukurniawan · Dec 1, 2024 · d23442c · d23442c
1 parent bdec3b9
commit d23442c
Show file tree

Hide file tree

Showing 12 changed files with 49 additions and 32 deletions.
diff --git a/...otlin-compiler-8903430381967892476.salive → ...otlin-compiler-2436125185968571723.salive b/...otlin-compiler-8903430381967892476.salive → ...otlin-compiler-2436125185968571723.salive
diff --git a/app/build.gradle b/app/build.gradle
@@ -103,9 +103,6 @@ android {
 
     buildFeatures {
         viewBinding true
-
-        // Fix compose compile error
-        compose true
     }
 
     compileOptions {
@@ -229,9 +226,9 @@ dependencies {
 
     // Analytics
     implementation platform(libs.google.firebase)
-    implementation 'com.google.firebase:firebase-analytics-ktx'
-    implementation 'com.google.firebase:firebase-perf-ktx'
-    implementation 'com.google.firebase:firebase-crashlytics-ktx'
+    implementation 'com.google.firebase:firebase-analytics'
+    implementation 'com.google.firebase:firebase-perf'
+    implementation 'com.google.firebase:firebase-crashlytics'
     implementation libs.wisnu.foundation.core.analytics
     implementation libs.wisnu.foundation.lib.analyticsmanager
 

diff --git a/...rc/main/java/com/wisnu/kurniawan/wallee/features/account/detail/ui/AccountDetailScreen.kt b/...rc/main/java/com/wisnu/kurniawan/wallee/features/account/detail/ui/AccountDetailScreen.kt
@@ -336,10 +336,10 @@ private fun AmountSection(
     }
 }
 
-private inline fun LazyListScope.AdjustAmountReasonCell(
+private fun LazyListScope.AdjustAmountReasonCell(
     data: List<AdjustBalanceReasonItem>,
     shouldShow: Boolean,
-    noinline onItemClick: (AdjustBalanceReasonItem) -> Unit
+    onItemClick: (AdjustBalanceReasonItem) -> Unit
 ) {
     if (shouldShow) {
         item {

diff --git a/.../main/java/com/wisnu/kurniawan/wallee/features/balance/summary/ui/BalanceSummaryScreen.kt b/.../main/java/com/wisnu/kurniawan/wallee/features/balance/summary/ui/BalanceSummaryScreen.kt
@@ -78,7 +78,10 @@ private fun BalanceSummaryScreen(
         LazyVerticalGrid(
             modifier = Modifier.fillMaxSize(),
             columns = GridCells.Adaptive(minSize = 150.dp),
-            horizontalArrangement = Arrangement.spacedBy(8.dp, alignment = Alignment.CenterHorizontally),
+            horizontalArrangement = Arrangement.spacedBy(
+                8.dp,
+                alignment = Alignment.CenterHorizontally
+            ),
             verticalArrangement = Arrangement.spacedBy(8.dp),
             contentPadding = PaddingValues(horizontal = 16.dp)
         ) {
@@ -149,10 +152,10 @@ private fun AllTimeSection(
     }
 }
 
-private inline fun LazyGridScope.AccountCell(
+private fun LazyGridScope.AccountCell(
     accountItems: List<AccountItem>,
-    noinline onClickAccount: (Account) -> Unit,
-    noinline onClickAddAccount: () -> Unit,
+    onClickAccount: (Account) -> Unit,
+    onClickAddAccount: () -> Unit,
 ) {
     item(span = { GridItemSpan(maxLineSpan) }) {
         Row(
@@ -180,7 +183,10 @@ private inline fun LazyGridScope.AccountCell(
             amountColor = it.account.getTotalBalanceColor(
                 MaterialTheme.colorScheme.onBackground
             ),
-            totalTransaction = stringResource(R.string.balance_total_transaction, it.totalTransaction),
+            totalTransaction = stringResource(
+                R.string.balance_total_transaction,
+                it.totalTransaction
+            ),
             updatedAt = it.account.getDateTimeDisplay(),
             isSelected = it.isSelected,
             textColor = it.getTextColor(),

diff --git a/...rc/main/java/com/wisnu/kurniawan/wallee/features/onboarding/data/OnboardingEnvironment.kt b/...rc/main/java/com/wisnu/kurniawan/wallee/features/onboarding/data/OnboardingEnvironment.kt
@@ -1,9 +1,9 @@
 package com.wisnu.kurniawan.wallee.features.onboarding.data
 
 import android.content.Context
-import com.google.firebase.crashlytics.ktx.crashlytics
-import com.google.firebase.crashlytics.ktx.setCustomKeys
-import com.google.firebase.ktx.Firebase
+import com.google.firebase.Firebase
+import com.google.firebase.crashlytics.crashlytics
+import com.google.firebase.crashlytics.setCustomKeys
 import com.wisnu.kurniawan.wallee.foundation.datasource.local.LocalManager
 import com.wisnu.kurniawan.wallee.foundation.datasource.preference.PreferenceManager
 import com.wisnu.kurniawan.wallee.foundation.extension.defaultAccount

diff --git a/app/src/main/java/com/wisnu/kurniawan/wallee/features/onboarding/ui/OnboardingScreen.kt b/app/src/main/java/com/wisnu/kurniawan/wallee/features/onboarding/ui/OnboardingScreen.kt
@@ -93,9 +93,11 @@ private fun OnboardingScreen(
         Header(
             onSettingClick = onSettingClick,
         )
-        Box(modifier = Modifier
-            .fillMaxSize()
-            .weight(1F)) {
+        Box(
+            modifier = Modifier
+                .fillMaxSize()
+                .weight(1F)
+        ) {
             Content(
                 state = state,
                 onItemClick = onItemClick,
@@ -181,10 +183,10 @@ private fun Content(
 }
 
 @OptIn(ExperimentalFoundationApi::class)
-private inline fun LazyListScope.CurrencyCell(
+private fun LazyListScope.CurrencyCell(
     data: Map<String, List<CurrencyItem>>,
     selectedCurrency: Currency?,
-    noinline onItemClick: (CurrencyItem) -> Unit,
+    onItemClick: (CurrencyItem) -> Unit,
 ) {
     item {
         Row(

diff --git a/.../main/java/com/wisnu/kurniawan/wallee/features/transaction/all/ui/AllTransactionScreen.kt b/.../main/java/com/wisnu/kurniawan/wallee/features/transaction/all/ui/AllTransactionScreen.kt
@@ -106,9 +106,9 @@ private fun Content(
     }
 }
 
-private inline fun LazyListScope.TransactionCell(
+private fun LazyListScope.TransactionCell(
     data: List<TransactionItem>,
-    noinline onItemClick: (TransactionItem) -> Unit,
+    onItemClick: (TransactionItem) -> Unit,
 ) {
     if (data.isEmpty()) {
         item {

diff --git a/...va/com/wisnu/kurniawan/wallee/features/transaction/summary/ui/TransactionSummaryScreen.kt b/...va/com/wisnu/kurniawan/wallee/features/transaction/summary/ui/TransactionSummaryScreen.kt
@@ -303,10 +303,10 @@ private fun CashFlowContent(
     }
 }
 
-private inline fun LazyListScope.LastTransactionCell(
+private fun LazyListScope.LastTransactionCell(
     data: List<TransactionItem>,
-    noinline onSeeMoreClick: () -> Unit,
-    noinline onItemClick: (TransactionItem) -> Unit,
+    onSeeMoreClick: () -> Unit,
+    onItemClick: (TransactionItem) -> Unit,
 ) {
     item {
         Row(
@@ -447,10 +447,10 @@ private fun TransactionItemCell(
 }
 
 
-private inline fun LazyListScope.TopExpenseCell(
+private fun LazyListScope.TopExpenseCell(
     data: List<TopExpenseItem>,
     currency: Currency,
-    noinline onSeeMoreClick: () -> Unit,
+    onSeeMoreClick: () -> Unit,
 ) {
     item {
         Row(

diff --git a/...in/java/com/wisnu/kurniawan/wallee/features/transaction/topexpense/ui/TopExpenseScreen.kt b/...in/java/com/wisnu/kurniawan/wallee/features/transaction/topexpense/ui/TopExpenseScreen.kt
@@ -91,7 +91,7 @@ private fun Content(
     }
 }
 
-private inline fun LazyListScope.TopExpenseCell(
+private fun LazyListScope.TopExpenseCell(
     data: List<TopExpenseItem>,
     currency: Currency,
 ) {

diff --git a/app/src/main/java/com/wisnu/kurniawan/wallee/foundation/datasource/local/WalleeReadDao.kt b/app/src/main/java/com/wisnu/kurniawan/wallee/foundation/datasource/local/WalleeReadDao.kt
@@ -2,6 +2,7 @@ package com.wisnu.kurniawan.wallee.foundation.datasource.local
 
 import androidx.room.Dao
 import androidx.room.Query
+import androidx.room.Transaction
 import com.wisnu.kurniawan.wallee.foundation.datasource.local.model.AccountDb
 import com.wisnu.kurniawan.wallee.foundation.datasource.local.model.AccountRecordDb
 import com.wisnu.kurniawan.wallee.foundation.datasource.local.model.AccountWithTransaction
@@ -20,6 +21,7 @@ interface WalleeReadDao {
     @Query("SELECT * FROM AccountDb")
     fun getAccounts(): Flow<List<AccountDb>>
 
+    @Transaction
     @Query("SELECT * FROM AccountDb")
     fun getAccountWithTransactions(): Flow<List<AccountWithTransaction>>
 

diff --git a/app/src/main/java/com/wisnu/kurniawan/wallee/foundation/theme/Theme.kt b/app/src/main/java/com/wisnu/kurniawan/wallee/foundation/theme/Theme.kt
@@ -1,5 +1,7 @@
 package com.wisnu.kurniawan.wallee.foundation.theme
 
+import android.os.Build
+import android.os.Build.VERSION.SDK_INT
 import androidx.appcompat.app.AppCompatActivity
 import androidx.compose.foundation.isSystemInDarkTheme
 import androidx.compose.material3.MaterialTheme
@@ -127,9 +129,17 @@ fun Theme(
 
         Theme.WALLPAPER -> {
             if (isSystemInDarkTheme()) {
-                dynamicDarkColorScheme(LocalContext.current)
+                if (SDK_INT >= Build.VERSION_CODES.S) {
+                    dynamicDarkColorScheme(LocalContext.current)
+                } else {
+                    NightColorPalette
+                }
             } else {
-                dynamicLightColorScheme(LocalContext.current)
+                if (SDK_INT >= Build.VERSION_CODES.S) {
+                    dynamicLightColorScheme(LocalContext.current)
+                } else {
+                    LightColorPalette
+                }
             }
         }
 

diff --git a/app/src/main/java/com/wisnu/kurniawan/wallee/foundation/uicomponent/Button.kt b/app/src/main/java/com/wisnu/kurniawan/wallee/foundation/uicomponent/Button.kt
@@ -91,7 +91,7 @@ fun PgButton(
 fun PgSecondaryButton(
     onClick: () -> Unit,
     modifier: Modifier = Modifier,
-    border: BorderStroke? = ButtonDefaults.outlinedButtonBorder,
+    border: BorderStroke? = ButtonDefaults.outlinedButtonBorder(),
     content: @Composable RowScope.() -> Unit
 ) {
     OutlinedButton(