Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wireviz.parse() #250

Merged
merged 10 commits into from
Aug 5, 2022
Merged

Improve wireviz.parse() #250

merged 10 commits into from
Aug 5, 2022

Conversation

17o2
Copy link
Collaborator

@17o2 17o2 commented Oct 16, 2021

Refactor and improve wireviz.parse().

  • More flexibility regarding supported types for inp argument
  • Allow multiple prepended files ($ wireviz -p prepend1.yml -p prepend2.yml mainfile.yml)
  • Customizable template separator; . stays as default
  • Cleanly distinguish between file output formats, and function return types
  • Better docstring

@17o2 17o2 added the in latest label Oct 16, 2021
@17o2 17o2 mentioned this pull request Oct 16, 2021
Open
@17o2 17o2 force-pushed the feature/isort-black branch from 1292f22 to c702e20 Compare October 16, 2021 20:32
@17o2 17o2 force-pushed the feature/improved-parse branch from 86c32ce to e31ed72 Compare October 16, 2021 20:32
@17o2 17o2 mentioned this pull request Aug 5, 2022
Open
5 tasks
Base automatically changed from feature/isort-black to feature/cli August 5, 2022 15:51
@17o2 17o2 merged commit e31ed72 into feature/cli Aug 5, 2022
@17o2 17o2 deleted the feature/improved-parse branch August 5, 2022 16:06
@martinrieder martinrieder mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@17o2