Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthycat patch 1 #158

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Synthycat patch 1 #158

merged 9 commits into from
Feb 21, 2025

Conversation

synthycat
Copy link
Contributor

@synthycat synthycat commented Feb 20, 2025

Описание изменения

Добавляет 3 интегратора и их лого в RU и EN локали сайта:

  • Tesliot
  • Abrom
  • IT Vision

Чеклист ревью

Перед мержем не забудь проверить:

  • правописание в тексте, опечатки

Опционально (но важно для изменений в инфраструктуру):

  • задеплоить на stage, чтобы проверить, что все работает

Summary by CodeRabbit

  • New Features

    • Added a new district entry representing Uzbekistan with updated location details.
    • Introduced integrator profiles for key partners, including ABROM, IT Vision, and TESLiOT, available in multiple languages.
  • Documentation

    • Expanded and refined partner company overviews with comprehensive service descriptions, contact details, and metadata for a clearer presentation to users.

В обе локали добавлен регион Узбекистан. В рамках задачи MAR-913 нужно добавить узбекского партнёра.
* Update districts.ts

В обе локали добавлен регион Узбекистан. В рамках задачи MAR-913 нужно добавить узбекского партнёра.

* Synthycat patch 3 (#155)

* Загрузка логотипов

it_vision.webp
abrom.webp
tesliot.webp

* Synthycat patch 4 (#154)

* Create tesliot.md

Добавляем интегратора tesliot на RU локаль сайта

* Synthycat patch 4 1 (#153)

* Update abrom.md

обновление информации об интеграторе в рамках задачи MAR-913

* Synthycat patch 5 (#152)

* Create it_vision.md

Добавляем интегратора IT Vision на RU локаль сайта

* Synthycat patch 6 (#151)

* Create tesliot.md

Добавляет интегратора tesliot на EN локаль сайта

* Synthycat patch 7 (#150)

* Create abrom.md

Добавляет интегратора abrom на EN локаль сайта

* Create it_vision.md (#149)

Добавляет интегратора IT Vision на EN локаль сайта
Редактировал описание, добавил bullet list
@synthycat synthycat requested review from a team as code owners February 20, 2025 15:02
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Warning

Rate limit exceeded

@synthycat has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a544bf and fc34d3e.

📒 Files selected for processing (1)
  • content/ru/_integrators/tesliot.md (1 hunks)

Walkthrough

This PR introduces new district entries for Uzbekistan in the common districts configuration, with separate values for Russian and English. Several markdown files have been added in the English and Russian integrators directories for companies ABROM, IT Vision, and TESLA SMART LLC, each containing metadata and detailed descriptions. The existing Russian ABROM file has been updated with revised district information, coordinates, and service details.

Changes

File Change Summary
common/districts.ts Added Uzbekistan district entries in both ru and en sections with value 'uz', coordinates [41.31, 69.26], label variations, and zoom level 10.
content/en/_integrators/*.md New markdown files for ABROM, IT Vision, and TESLA SMART LLC added with metadata (district, tags, coordinates, title, logo, phone, website, email) and descriptions.
content/ru/_integrators/*.md Updated abrom.md with a simplified district, updated coordinates, and revised service details; added new files for IT Vision and TESLA SMART LLC.

Possibly related PRs

  • Update districts.ts #141: The changes in the main PR are directly related to those in this PR, as both introduce new entries for Uzbekistan in the districts constant within the common/districts.ts file.
  • add kz district and district availability check #98: The changes in the main PR, which add new entries for Uzbekistan in the districts constant, are related to this PR that adds a new district entry for Kazakhstan in the same districts constant.
  • MAR-913 Add 3 integrators to website #157: The changes in the main PR are directly related to those in this PR as both introduce new entries for Uzbekistan in the districts constant within the common/districts.ts file.

Suggested reviewers

  • dnnik
  • KraPete

Poem

Hop, hop, hop, I bounce through lines of code,
Adding districts and integrators on a bright new road.
Uzbekistan joins our map with a neat little twist,
Each file sings its story, impossible to resist.
A hoppy cheer from me, the coding bunny at play!
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ekateluv
Copy link

Привет, назвай пожалуйста пр-ы по смыслу изменений

ninedev-i
ninedev-i previously approved these changes Feb 21, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
content/ru/_integrators/abrom.md (1)

15-20: Improve list formatting consistency.

The bullet points should start immediately after the colon without a line break for better readability.

-Abrom выполняет полный цикл работ, включая:
-
-- проектирование систем электроснабжения, домашней автоматизации, СКС и инженерных решений;
+Abrom выполняет полный цикл работ, включая: 
+- проектирование систем электроснабжения, домашней автоматизации, СКС и инженерных решений;
content/en/_integrators/abrom.md (1)

16-21: Fix grammatical issue with colon usage.

Remove the colon when using 'including' as a preposition:

-Abrom provides a full range of services, including:  
-- designing power supply systems, home automation, structured cabling systems (SCS), and engineering solutions;  
+Abrom provides a full range of services, including
+- designing power supply systems, home automation, structured cabling systems (SCS), and engineering solutions;  
🧰 Tools
🪛 LanguageTool

[typographical] ~16-~16: Do not use a colon (:) before a series that is introduced by a preposition (‘including’). Remove the colon or add a noun or a noun phrase after the preposition.
Context: ...brom provides a full range of services, including: - designing power supply systems, hom...

(RP_COLON)

content/en/_integrators/tesliot.md (1)

1-10: Metadata Block Review: Verify Consistency and Accuracy

The metadata block is well structured and includes all the required keys (district, tags, coordinates, title, logo, phone, website, and email). Please double-check that the company name ("TESLA SMART LLC") in the metadata matches the intended branding, as the filename and context refer to "tesliot".

content/ru/_integrators/tesliot.md (1)

12-15: Content Review: Minor Punctuation Enhancement Suggested

The Russian text effectively conveys the integrator’s profile and services. However, the static analysis flagged a potential punctuation improvement in line 14. To improve clarity, consider adding a comma in the phrase:

  • Current: “… решения на основе Bluetooth 5.2, такие как базовые станции …”
  • Suggested: “… решения на основе Bluetooth 5.2, такие, как базовые станции …”

This minor adjustment aligns with standard Russian punctuation recommendations.

-Линейка продукции включает передовые решения на основе Bluetooth 5.2, такие как базовые станции и датчики, обеспечивающие высокоскоростной обмен данными, увеличенную дальность связи, энергоэффективность и надежность.
+Линейка продукции включает передовые решения на основе Bluetooth 5.2, такие, как базовые станции и датчики, обеспечивающие высокоскоростной обмен данными, увеличенную дальность связи, энергоэффективность и надежность.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~14-~14: Пропущена запятая: «такие, как»
Context: ...едовые решения на основе Bluetooth 5.2, такие как базовые станции и датчики, обеспечивающ...

(TAKOJ_KAK)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae7c7e0 and dd53154.

📒 Files selected for processing (7)
  • common/districts.ts (1 hunks)
  • content/en/_integrators/abrom.md (1 hunks)
  • content/en/_integrators/it_vision.md (1 hunks)
  • content/en/_integrators/tesliot.md (1 hunks)
  • content/ru/_integrators/abrom.md (1 hunks)
  • content/ru/_integrators/it_vision.md (1 hunks)
  • content/ru/_integrators/tesliot.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • content/en/_integrators/it_vision.md
🧰 Additional context used
🪛 LanguageTool
content/en/_integrators/abrom.md

[typographical] ~16-~16: Do not use a colon (:) before a series that is introduced by a preposition (‘including’). Remove the colon or add a noun or a noun phrase after the preposition.
Context: ...brom provides a full range of services, including: - designing power supply systems, hom...

(RP_COLON)

content/ru/_integrators/tesliot.md

[uncategorized] ~14-~14: Пропущена запятая: «такие, как»
Context: ...едовые решения на основе Bluetooth 5.2, такие как базовые станции и датчики, обеспечивающ...

(TAKOJ_KAK)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: docker
🔇 Additional comments (6)
common/districts.ts (1)

13-13: LGTM! New district entries for Uzbekistan are well-structured.

The additions follow the established patterns:

  • Coordinates correctly point to Tashkent
  • Zoom level (10) matches other country entries
  • Labels are appropriately localized

Also applies to: 19-19

content/ru/_integrators/abrom.md (1)

2-3: LGTM! District and coordinates updated as requested.

Changes align with previous review feedback to simplify the district to 'kg' and update coordinates accordingly.

content/en/_integrators/abrom.md (1)

7-8: Verify contact information consistency.

The phone number and website URL differ from the Russian version:

Please confirm which details are correct.

content/ru/_integrators/it_vision.md (1)

1-15: LGTM! Well-structured integrator profile.

The metadata is correctly formatted, tags are appropriate, and the content provides a clear and comprehensive overview of IT Vision's services.

content/en/_integrators/tesliot.md (1)

12-15: Content Review: Clear and Informative Description

The main content clearly details the services and product offerings. No spelling errors or typos were detected, and the technical language (e.g., “Bluetooth 5.2-based solutions”) is precise.

content/ru/_integrators/tesliot.md (1)

1-10: Metadata Block Review: Consistency and Completeness

The metadata is correctly populated with all the necessary fields. As with the English version, please ensure that the company name and visual assets align with the intended branding.

Copy link
Contributor Author

@synthycat synthycat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

требуемые изменения внесены

@synthycat synthycat merged commit ef3b2fd into main Feb 21, 2025
3 checks passed
@synthycat synthycat deleted the synthycat-patch-1 branch February 21, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants