Bugfix/subtitle localization #106

ninedev-i · 2025-01-14T15:45:56Z

Поправил заголовок страницы en и формат даты

Summary by CodeRabbit

Internationalization (i18n)
- Enhanced localization support for the Article component
- Updated page metadata with dynamic translations
- Added translation keys for Russian and English locales for the Solutions page title

coderabbitai · 2025-01-14T15:46:06Z

Walkthrough

The pull request introduces localization improvements across two Vue components. The changes focus on enhancing internationalization by modifying date formatting in the Article.vue component and updating metadata translations in the solutions page. The modifications enable more dynamic and locale-specific content rendering, with specific adjustments to how dates and page titles are displayed based on the current language setting.

Changes

File	Change Summary
`components/Article.vue`	Added `useI18n()` dependency and `locale` constant. Implemented conditional date formatting based on locale, with special handling for Russian locale
`pages/contents/solutions/[slug].vue`	Updated metadata title to use dynamic translation reference `${t('title')}`. Added translation keys for 'title' in Russian and English locales

Poem

🌍 Locales dancing, bits in flight,
Translations bloom with pure delight
Russian, English, words take wing
Our code now speaks each language's ring!
🐰✨ Internationalization's sweet embrace

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

components/Article.vue (1)
22-24: Consider using locale-specific date formats.

The current implementation forces English month names for Russian locale, which might not be the best user experience. Consider:

Using Russian month names for Russian locale

Moving date formats to i18n configuration for better maintainability
-        {{ locale === 'ru' ? dayjs(date).locale('en').format('D MMMM YYYY') : dayjs(date).format('MMM D, YYYY') }}
+        {{ dayjs(date).locale(locale).format(locale === 'ru' ? 'D MMMM YYYY' : 'MMM D, YYYY') }}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d54a2b8 and e893111.

📒 Files selected for processing (2)

components/Article.vue (2 hunks)
pages/contents/solutions/[slug].vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Codacy Static Code Analysis
GitHub Check: docker

🔇 Additional comments (3)

components/Article.vue (1)

8-8: LGTM! Good i18n practice.

Using useI18n() to get the current locale is the correct approach for internationalization.

pages/contents/solutions/[slug].vue (2)

13-13: LGTM! Well-implemented breadcrumb localization.

The breadcrumb meta tag correctly uses both the dynamic locale for the path and the translated title.

75-75: LGTM! Clear and concise translations.

The translations for both Russian ("Примеры внедрений") and English ("Solutions") are appropriate and maintain the meaning across languages.

Also applies to: 81-81

KraPete · 2025-01-14T16:50:45Z

components/Article.vue

@@ -18,7 +19,9 @@ const to = props.url || `${route.path}${route.path.at(-1) === '/' ? '' : '/'}${p
    />
    <div>
      <h4 class="article-title">{{ title }}</h4>
-      <time :datetime="date" class="article-date">{{ dayjs(date).locale('ru').format('D MMMM YYYY') }}</time>
+      <time :datetime="date" class="article-date">
+        {{ locale === 'ru' ? dayjs(date).locale('en').format('D MMMM YYYY') : dayjs(date).format('MMM D, YYYY') }}


i18n же умеет во всякое хитрое форматирование в зависимости от локали. Почему это в переводы не перенести? Выглядело бы более красиво

ninedev-i added 2 commits January 14, 2025 18:33

fix subtitle

d7a27f5

fix date

e893111

ninedev-i requested a review from lostpoint-ru January 14, 2025 15:45

ninedev-i requested a review from a team as a code owner January 14, 2025 15:45

coderabbitai bot reviewed Jan 14, 2025

View reviewed changes

lostpoint-ru approved these changes Jan 14, 2025

View reviewed changes

ninedev-i merged commit c3d70e9 into main Jan 14, 2025
3 checks passed

ninedev-i deleted the bugfix/subtitle-localization branch January 14, 2025 15:57

KraPete reviewed Jan 14, 2025

View reviewed changes

This was referenced Jan 22, 2025

move category filter to separate component #118

Merged

add include component #119

Merged

coderabbitai bot mentioned this pull request Feb 11, 2025

fix article date locale #133

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/subtitle localization #106

Bugfix/subtitle localization #106

ninedev-i commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

KraPete Jan 14, 2025

Bugfix/subtitle localization #106

Bugfix/subtitle localization #106

Conversation

ninedev-i commented Jan 14, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jan 14, 2025 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

KraPete Jan 14, 2025

Choose a reason for hiding this comment

ninedev-i commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)