Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespace parameter to equalToXml. #2954

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

RafeArnold
Copy link
Contributor

@RafeArnold RafeArnold commented Feb 4, 2025

Previously, the behaviour of EqualToXmlPattern in regards to XML namespaces was inconsistent and hard to predict. This PR attempts to define this behaviour and add additional options to be more explicit about how namespaces should be handled.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@RafeArnold RafeArnold requested a review from a team as a code owner February 4, 2025 13:45
with the intent to make namespace behaviour more predictable, consistent
and configurable.
@RafeArnold
Copy link
Contributor Author

docs wiremock/wiremock.org#335

@RafeArnold RafeArnold marked this pull request as draft February 5, 2025 11:07
@RafeArnold RafeArnold force-pushed the equal-to-xml-namespace-awareness branch from 4f41100 to df16888 Compare February 5, 2025 11:27
@RafeArnold RafeArnold marked this pull request as ready for review February 5, 2025 11:27
@tomakehurst tomakehurst merged commit 5c220de into master Feb 5, 2025
11 checks passed
@tomakehurst tomakehurst deleted the equal-to-xml-namespace-awareness branch February 5, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants