Disable WireMock banner in the CLI output by default #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
requested changes
May 23, 2023
There was a problem hiding this comment.
Hello, thanks a lot for the pull request! I think the same test could be better done without Mockito, and that it would be better for future test coverage. So I would suggest an update to the implementation and maybe adding the necessary public or package-scope API
src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java
Outdated
Show resolved
Hide resolved
src/test/java/org/wiremock/integrations/testcontainers/WireMockContainerJUnit5Test.java
Outdated
Show resolved
Hide resolved
src/test/java/org/wiremock/integrations/testcontainers/WireMockContainerJUnit5Test.java
Outdated
Show resolved
Hide resolved
src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleg Nenashev <[email protected]>
…-michelmann/wiremock-testcontainers-java into feature/disable-banner-by-default
julian-michelmann
changed the title
src/main/java/org/wiremock/integrations/testcontainers/WireMockContainer.java
Show resolved
Hide resolved
oleg-nenashev
approved these changes
May 23, 2023
There was a problem hiding this comment.
I am fine with the change per se. @julian-michelmann do you want to exclude the Mockito in this pull request? If not, I can do it in a follow-up PR. Would be nice to integrate the withBanner() suggestion though
oleg-nenashev
changed the title
|
Oh, it's okay I will do this I only need another second. I may convert my PR to draft state, sorry... |
oleg-nenashev
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the container is running by default with the cli arg --disabled. When using the verbose flag, the banner is shown when starting.
References
Issue -> #31
Submitter checklist