Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JUnit5 test coverage and documentation #16

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Add JUnit5 test coverage and documentation #16

merged 4 commits into from
Apr 23, 2023

Conversation

kapishmalik
Copy link
Contributor

@kapishmalik kapishmalik commented Apr 23, 2023 •
edited
Loading

@oleg-nenashev I have added existing example tests in JUnit 5.

Resolves #8

oleg-nenashev
oleg-nenashev reviewed Apr 23, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Since we have multiple examples now, it would be great to also add titles to JUnit4 and JUnit5 examples so that they are visible in the table of contents

@kapishmalik
Copy link
Contributor Author

kapishmalik commented Apr 23, 2023 •
edited
Loading

incorporated review comment

@oleg-nenashev oleg-nenashev mentioned this pull request Apr 23, 2023
Closed
@oleg-nenashev oleg-nenashev self-requested a review April 23, 2023 17:22
oleg-nenashev
oleg-nenashev reviewed Apr 23, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to also update the ### Using the test container in JUnit 4/5 section with the JUnit 5 example. Arguably, JUnit 5 should go first and be used as a default in all other documentation sections that do not require both JUnit 4 and JUnit 5 examples
`

oleg-nenashev
oleg-nenashev approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will see how to optimize the vertical size of the examples later, maybe with expandable sections. But it looks good content-wise

@oleg-nenashev oleg-nenashev added documentation Improvements or additions to documentation chore Maintenance labels Apr 23, 2023
@oleg-nenashev oleg-nenashev changed the title Add JUnit5 example and documentation Add JUnit5 test coverage and documentation Apr 23, 2023
@oleg-nenashev oleg-nenashev merged commit ee392b6 into wiremock:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
chore Maintenance documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JUnit 5 support test coverage and documentation
2 participants
@kapishmalik @oleg-nenashev