Add a testcontainers_wiremock#RunContainerAndStopOnCleanup() method to simplify automatic termination

[Vayras]

As per the issue I have containerize the code the update code is in a new branch with same name as the issue

References

• TODO

Submitter checklist

• The PR request is well described and justified, including the body and the references
• The PR title represents the desired changelog entry
• The repository's code style is followed (see the contributing guide)
• Test coverage that demonstrates that the change works as expected
• For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

[oleg-nenashev]

Thanks for the pull request. I would actually expect not refactoring of a test case, but adding a new method in https://github.com/wiremock/wiremock-testcontainers-go/blob/main/tc-wiremock.go that makes the test more simple

It could be RunContainerAndStopOnCleanup() or so that takes the testing context as an extra argument

[Vayras]

@oleg-nenashev thanks for your feedback , correct me if I'm wrong , the method needs to written in the tc-wiremock.go and used in the quickstart_test.go?

[oleg-nenashev]

@Vayras yup, this is correct. See #21 for inspiration

[Vayras]

@oleg-nenashev should I implement these changes?

[oleg-nenashev]

@Vayras this is an expectation in #27

[Vayras]

@oleg-nenashev Okay , working on this

[Vayras]

@oleg-nenashev I have commited and pushed some changes using terminal can you please let me know if they reflect and are updated?

[oleg-nenashev]

Thank you! It gets closer but we need to replace the /hello hardcoding by a proper mapping of parameters

[oleg-nenashev]

That part needs to be parameterizable and, preferably, taking the same array as a RunContainer method

[Vayras]

@oleg-nenashev Thank you for your feedback , will make these changes

[Vayras]

I believe that by adding an 'Id' parameter, the issue will be resolved. I have made this change to the file

[oleg-nenashev]

@Vayras I suggest keeping the original RunContainerSomething(ctx context.Context, opts ...testcontainers.ContainerCustomizer) interface so that the code is more flexible. You would need to just take this array as an argument and pass to the nested method

[Vayras]

with this you can call the function like this :
container, err := RunContainerAndStopOnCleanup(ctx, t, []testcontainers.ContainerCustomizer{ WithMappingFile(id, mappingFileName), WithImage("customimage"), // Add other customizers })

[oleg-nenashev]

Thanks! Let's see how the CI runs, and happy to integrate it afterwards

[oleg-nenashev]

Thanks! I will update the README in the downstream PR, because there are a few other changes I wanted to land anyway

[Vayras]

@oleg-nenashev It's truly been a great experience collaborating with you on this project. If the thought crosses your mind, I'd be honored to discuss the possibility of sponsorship for my work or even the potential of becoming a part of this organization. Please feel free to reach out anytime. I'm always eager to contribute my skills and expertise to address challenges as effectively as I can.

[oleg-nenashev]

@Vayras from what I understand, you're just starting with Golang. I might be open to discuss various open source internship options in the future, but at the same time I want to highlight that asking for being paid for your work in the future after doing a single newcomer friendly contribution is unlikely to be perceived well by maintainers. So I recommend to revise the message above if you send it to other projects

[Vayras]

@oleg-nenashev Thank you for addressing this , finding an open source internship related to Golang would be very beneficial for me, and I think open source contribution , even with whatever little I do , keeps me motivated ,I'm fairly new to Golang , I have recently picked up learning this language any opportunity to get better at it is deeply appreciated.