Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add full emoji selection for In-call reactions [WPB-15113] #18715

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: add full emoji selection for In-call reactions [WPB-15113] #18715

merged 1 commit into from
Feb 6, 2025

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Feb 6, 2025 •
edited by github-actions bot
Loading

TaskWPB-15113 Allow for full selection of emojis in in-call reactions

Description

This feat enhances in-call reactions by allowing users to select from the full range of emojis, rather than being limited to a predefined set.

Screenshots/Screencast (for UI changes)

video1.mov
video2.mov

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@waseemansar waseemansar requested review from otto-the-bot and a team as code owners February 6, 2025 08:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

e-maad
e-maad approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@waseemansar waseemansar merged commit 9135721 into dev Feb 6, 2025
15 of 16 checks passed
@waseemansar waseemansar deleted the feat/emojis-in-call-reactions-WPB-15113 branch February 6, 2025 13:06
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-maad e-maad e-maad approved these changes

@przemvs przemvs przemvs approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: L type: feature / request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@waseemansar @e-maad @przemvs @otto-the-bot @paulwire