Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sign out other instance when logged in with new instance [WPB-15071] #18710

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

e-maad
Copy link
Contributor

@e-maad e-maad commented Feb 3, 2025

BugWPB-15071 [Web] Redirection of Netnod production

Description

Previously we navigated user to the app if the user has active session, #18655.
That changed caused some issue if the user is logged into another tab and try to login on another. The user stuck on the loop where one tab try to end the session and another auto login with existing session. Now, I added check to logout if the user want to start a new session from another tab.

Note: The changes are still behind feature flag FEATURE.ENABLE_AUTO_LOGIN

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@e-maad e-maad requested review from otto-the-bot and a team as code owners February 3, 2025 14:57
@echoes-hq echoes-hq bot added the echoes: unplanned/support Work items completed to meet a customer or user support request. label Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 45.93%. Comparing base (dd24eab) to head (1375368).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18710      +/-   ##
==========================================
- Coverage   45.94%   45.93%   -0.01%     
==========================================
  Files         925      925              
  Lines       27674    27678       +4     
  Branches     6249     6250       +1     
==========================================
+ Hits        12714    12715       +1     
- Misses      13379    13382       +3     
  Partials     1581     1581              

@e-maad e-maad merged commit c0e9b2c into dev Feb 3, 2025
16 checks passed
@e-maad e-maad deleted the fix/sign-out-intance-on-new-login-WPB-15071 branch February 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned/support Work items completed to meet a customer or user support request. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants