Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use backend config for 1 on 1 SFT calls #18063

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore: use backend config for 1 on 1 SFT calls #18063

merged 1 commit into from
Sep 19, 2024

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Sep 18, 2024 •
edited
Loading

StoryWPB-7151 [Web] Add flag for customer specific 1:1 calls in federated environment

Description

see #17759

The backend configuration is now correct for 1:1 SFT call , we can use the backend feature flag instead of hardcoding the value in the feature branch

Checklist

  • mentions the JIRA issue in the PR name (Ex. WPB-423)
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@V-Gira V-Gira requested review from otto-the-bot and a team as code owners September 18, 2024 14:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@V-Gira V-Gira merged commit 49012ec into release/q1-2024 Sep 19, 2024
22 checks passed
@V-Gira V-Gira deleted the v/sft-1on1 branch September 19, 2024 08:09
V-Gira added a commit that referenced this pull request Sep 19, 2024
@V-Gira
chore: use backend config for 1 on 1 SFT calls (#18063)
70736ab
V-Gira added a commit that referenced this pull request Sep 19, 2024
@V-Gira
chore: use backend config for 1 on 1 SFT calls (#18063)
6fe27ce
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Sep 20, 2024
V-Gira added a commit that referenced this pull request Sep 23, 2024
@V-Gira
chore: use backend config for 1 on 1 SFT calls (#18063)
323443f
V-Gira added a commit that referenced this pull request Sep 23, 2024
@V-Gira @PatrykBuniX @przemvs
chore: cherry-pick MLS 1:1 conversation over SFT to dev [WPB-10120] (#…
d89b2a9 
…18066)

* runfix: treat 1:1 calls as conference calls (#17759)

* fix: handle leaving a 1:1 call over SFT [WPB-7151] (#17883)

* feat: establish 1on1 mls conversation with new removal key [WPB-10744] (#18062)

* chore: use backend config for 1 on 1 SFT calls (#18063)

* chore: address remaining merge conflicts

* Update src/script/calling/CallingRepository.ts

Co-authored-by: Przemysław Jóźwik <[email protected]>

* chore: show quality feedback modal if countly enabled

* chore: bump core to 46.4.0

---------

Co-authored-by: Patryk Górka <[email protected]>
Co-authored-by: Przemysław Jóźwik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemvs przemvs przemvs approved these changes

@tlebon tlebon tlebon approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
comp: calling echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 👕 size: S type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@V-Gira @przemvs @tlebon @otto-the-bot