chore: allow support for appended URL paths [WPB-10937] #18013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: allow end user to set all url paths (WPB-4676) * add new urls in env variables to config * remove hard coded path from externalRoutes util * update components using the externalRoutes util * update missing components * remove unused path * rename subpath to url_path * expose external urls instead of get methods * add JS doc to methods appending UTM parameters * Apply suggestions from code review Co-authored-by: Przemysław Jóźwik <[email protected]> --------- Co-authored-by: Virgile <[email protected]> Co-authored-by: Przemysław Jóźwik <[email protected]>
echoes-hq
bot
added
the
echoes: unplanned
|
thisisamir98
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's been decided to include support of configurable appended url path to the release branch.
This is a cherry pick of 899ddd1 #16774 from dev
The default config is bumped to the appropriate version, providing default values for the new env variables.
See commit history: https://github.com/wireapp/wire-web-config-wire/commits/master/ https://github.com/wireapp/wire-web-config-default/commits/master/
Checklist