refactor: Minor enrollment class improvements #16545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Jan 18, 2024
Comment on lines
-390
to
-396
| private shouldShowNotification(): boolean { | ||
| // If the user has already snoozed the notification, don't show it again until the snooze period has expired | ||
| if (this.currentStep === E2EIHandlerStep.SNOOZE) { | ||
| return false; | ||
| } | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This is actually covered by the check on this line https://github.com/wireapp/wire-webapp/pull/16545/files#diff-080531c7467e54b71bd1e9e26a2d57a487984bf982fefb3f7afc152640f7da23R435
PatrykBuniX
approved these changes
Jan 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #16545 +/- ##
=======================================
Coverage 45.43% 45.43%
=======================================
Files 740 740
Lines 24241 24238 -3
Branches 5507 5506 -1
=======================================
- Hits 11013 11012 -1
+ Misses 11819 11818 -1
+ Partials 1409 1408 -1 |
V-Gira
approved these changes
Jan 18, 2024
przemvs
approved these changes
Jan 18, 2024
arjita-mitra
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated logic that is not needed anymore
Checklist