chore: Stop processing team events (WPB-4538) #16471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/q1-2024 #16471 +/- ##
==================================================
Coverage ? 45.76%
==================================================
Files ? 745
Lines ? 24408
Branches ? 5570
==================================================
Hits ? 11170
Misses ? 11820
Partials ? 1418 |
atomrc
reviewed
Jan 18, 2024
atomrc
reviewed
Jan 18, 2024
| @@ -8771,12 +8771,12 @@ __metadata: | |||
| linkType: hard | |||
|
|
|||
| "follow-redirects@npm:^1.15.4": | |||
| version: 1.15.4 | |||
| resolution: "follow-redirects@npm:1.15.4" | |||
| version: 1.15.5 | |||
There was a problem hiding this comment.
This change is suspicious 🤔
atomrc
reviewed
Jan 18, 2024
src/script/event/preprocessor/EventStorageMiddleware/EventStorageMiddleware.ts
Show resolved
Hide resolved
atomrc
approved these changes
Jan 18, 2024
…ageMiddleware.ts Co-authored-by: Thomas Belin <[email protected]>
thisisamir98
force-pushed
the
chore/wpb-4538
branch
from
fffc1e5 to
77b76c6
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
* chore: Stop processing team events (WPB-4538) * bump core * add User is not part of the conversation * add testing * handle pure MemberLeaveReason.USER_DELETED * Update src/script/event/preprocessor/EventStorageMiddleware/EventStorageMiddleware.ts Co-authored-by: Thomas Belin <[email protected]> * chore: lint --------- Co-authored-by: Thomas Belin <[email protected]>
otto-the-bot
added a commit
that referenced
this pull request
Feb 1, 2024
* chore: Stop processing team events (WPB-4538) * bump core * add User is not part of the conversation * add testing * handle pure MemberLeaveReason.USER_DELETED * Update src/script/event/preprocessor/EventStorageMiddleware/EventStorageMiddleware.ts * chore: lint --------- Co-authored-by: Amir Ghezelbash <[email protected]> Co-authored-by: Thomas Belin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following team events are deprecated on backend and we need to skip processing them, expect the
team.member-leavewhich we need to keep for backward compatibility.team.member-join
team.member-leave
team.update
team.member-update