fix: Avoid maximum update depth exceeded error by ref comparison (WPB…

…-11955) (#18712)
wireapp · Feb 5, 2025 · d57b497 · d57b497
1 parent c0e9b2c
commit d57b497
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/script/page/LeftSidebar/panels/Conversations/Conversations.tsx b/src/script/page/LeftSidebar/panels/Conversations/Conversations.tsx
@@ -348,6 +348,7 @@ export const Conversations: React.FC<ConversationsProps> = ({
             searchInputRef={searchInputRef}
           />
         }
+        conversationListRef={conversationListRef}
         setConversationListRef={setConversationListRef}
         hasHeader={!isPreferences}
         sidebar={

diff --git a/src/script/page/LeftSidebar/panels/ListWrapper.tsx b/src/script/page/LeftSidebar/panels/ListWrapper.tsx
@@ -57,6 +57,7 @@ interface LeftListWrapperProps {
   onClose?: () => void;
   hasHeader?: boolean;
   conversationsFilter?: string;
+  conversationListRef?: HTMLElement | null;
   setConversationListRef?: (element: HTMLElement) => void;
 }
 
@@ -72,6 +73,7 @@ const ListWrapper = memo(
     footer,
     before,
     headerUieName,
+    conversationListRef,
     setConversationListRef,
   }: LeftListWrapperProps) => {
     const calculateBorders = throttle((element: HTMLElement) => {
@@ -91,7 +93,9 @@ const ListWrapper = memo(
         return;
       }
 
-      setConversationListRef?.(element);
+      if (element !== conversationListRef) {
+        setConversationListRef?.(element);
+      }
 
       calculateBorders(element);
       element.addEventListener('scroll', () => calculateBorders(element));