Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): replace btoa with bazinga in e2ei storage #5899

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(core): replace btoa with bazinga in e2ei storage #5899

merged 1 commit into from
Jan 24, 2024

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Jan 23, 2024 •
edited by atomrc
Loading

window.atob and window.btoa doesn't handle non ascii character.
Instead we should use bazinga64's primitive to encode and decode e2ei payloads

@atomrc atomrc merged commit e8ec491 into main Jan 24, 2024
7 checks passed
@atomrc atomrc deleted the fix/e2ei-storage-replace-btoa-with-bazinga branch January 24, 2024 09:46
@atomrc atomrc mentioned this pull request Jan 24, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomrc atomrc atomrc approved these changes

Assignees
No one assigned
Labels
type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przemvs @atomrc @otto-the-bot