Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clrProxy field of MLSE2EId feature flag #4233

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Fix clrProxy field of MLSE2EId feature flag #4233

merged 7 commits into from
Sep 17, 2024

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 11, 2024 •
edited by battermann
Loading

https://wearezeta.atlassian.net/browse/WPB-10985

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti
Fix rowToFeature for MlsE2EI
c4a5405 
A missing `crlProxy` field should not override the default value. Same for
`acmeDiscoveryUrl`.
@pcapriotti
WIP: add crlProxy to test configuration
1121b5e
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Sep 11, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 11, 2024
@battermann battermann marked this pull request as ready for review September 13, 2024 11:47
@battermann battermann mentioned this pull request Sep 13, 2024
Merged
2 tasks
@pcapriotti pcapriotti merged commit 3b191f0 into develop Sep 17, 2024
10 checks passed
@pcapriotti pcapriotti deleted the mls-feature-flag-bug branch September 17, 2024 09:39
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
This was referenced Oct 23, 2024
Closed
Closed
@zebot zebot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @battermann @zebot @stefanwire