-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Simplify email types #4206
Conversation
79f152a
to
1a6ca21
Compare
5048386
to
cd83f4d
Compare
emails
field in SCIM user record45a6751
to
063caf0
Compare
libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/Email_user.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of diff in golden tests. They pretty much all seem to be facing the same issue: a change in the string value where no change was needed, at least that's my hunch (e.g., replacing Email {emailLocal = "OR\32966c", emailDomain = "\RS\ENQr"}
with unsafeEmailAddress "some" "example"
. If it's the case that the former is not a valid email address, then I can see how the change is justified, but please confirm.
libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/Invitation_team.hs
Show resolved
Hide resolved
libs/wire-api/test/golden/Test/Wire/API/Golden/Generated/NewUserPublic_user.hs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's stuff to improve. See comments inlined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you fix the two remaining TODOs, this is good to go.
In Spar.Scim.User
you still have this comment:
TODO(elland): verify with fisx if this still applies.
And another one:
TODO: validate fallback emails?
3b6d5dd
to
68a03de
Compare
f4a06a3
to
73161b1
Compare
This factors out one of our email types in favour of a validated email, this means a lot of tests that created arbitrary bytestrings became invalid and were replaced with simple valid emails, this might have caused redundancy in some of the golden tests.
https://wearezeta.atlassian.net/browse/WPB-665
Checklist
changelog.d