Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts/{brig,galley}: Allow setting a preStop hook for the deployments #4200

Merged
merged 3 commits into from
Aug 13, 2024
Merged

charts/{brig,galley}: Allow setting a preStop hook for the deployments #4200

merged 3 commits into from
Aug 13, 2024

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Aug 12, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-9075

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Aug 12, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 12, 2024
@akshaymankar
Copy link
Member Author

akshaymankar commented Aug 12, 2024 •
edited
Loading

The idea is that we'll deploy profiling builds and set this value to upload the profile data somewhere. This was when k8s decides to kill the container, the profile data won't get lost.

lwille
lwille requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@lwille lwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found two tiny issues

@lwille
Copy link
Contributor

lwille commented Aug 12, 2024

feel free to merge once CI is green :)

@akshaymankar akshaymankar merged commit 19e5f55 into develop Aug 13, 2024
10 checks passed
@akshaymankar akshaymankar deleted the brig-galley-pre-stop branch August 13, 2024 07:00
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
This was referenced Oct 23, 2024
Closed
Closed
@zebot zebot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwille lwille lwille approved these changes

Assignees
No one assigned
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @lwille @zebot