-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable manual usage of locally running wire-server #4176
Conversation
770c444
to
f3834aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks. Other than that: LGTM 👍
## How to run the webapp locally against locally running backend | ||
|
||
1. Clone the webapp from: https://github.com/wireapp/wire-webapp | ||
2. Install these depedencies needed for the webapp: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a perfect world, webapp
would have a nix environment because NodeJS et. al. aren't endlessly backwards compatible...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking, but then I thought clearly noone would maintain that. So, its probably fine to just nix shell nixpkgs#nodejs ...
let smtpEndpoint = object ["host" .= "localhost", "port" .= (2500 :: Int)] | ||
authSettings = | ||
object | ||
[ "userTokenTimeout" .= (4838400 :: Int), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm usually too lazy to calculate and would write a let
or where
binding for such numbers. E.g. fiftysixDays = 4838400
.
But, that's probably a matter of taste 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copy pasted these from default values of the helm charts and I have no clue what they correspond to, I'd wager noone would care about this until they testing something specific at which point they'd probably just change the values temporarily.
d2b4c1f
to
f6cf253
Compare
Co-authored-by: Sven Tennie <[email protected]>
f6cf253
to
94d5957
Compare
Webapp repository needed a little change for this to work: wireapp/wire-webapp#17844
Checklist
changelog.d