Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manual usage of locally running wire-server #4176

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Jul 31, 2024

Webapp repository needed a little change for this to work: wireapp/wire-webapp#17844

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 31, 2024
@akshaymankar akshaymankar marked this pull request as ready for review July 31, 2024 10:26
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks. Other than that: LGTM 👍

## How to run the webapp locally against locally running backend

1. Clone the webapp from: https://github.com/wireapp/wire-webapp
2. Install these depedencies needed for the webapp:
Copy link
Contributor

@supersven supersven Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a perfect world, webapp would have a nix environment because NodeJS et. al. aren't endlessly backwards compatible...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was thinking, but then I thought clearly noone would maintain that. So, its probably fine to just nix shell nixpkgs#nodejs ...

let smtpEndpoint = object ["host" .= "localhost", "port" .= (2500 :: Int)]
authSettings =
object
[ "userTokenTimeout" .= (4838400 :: Int),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually too lazy to calculate and would write a let or where binding for such numbers. E.g. fiftysixDays = 4838400.

But, that's probably a matter of taste 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy pasted these from default values of the helm charts and I have no clue what they correspond to, I'd wager noone would care about this until they testing something specific at which point they'd probably just change the values temporarily.

@akshaymankar akshaymankar merged commit 0f192f8 into develop Oct 17, 2024
10 checks passed
@akshaymankar akshaymankar deleted the local-manual-usage branch October 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants