-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Weed out dead code (part 2) #4173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59e8c83
to
395a8f2
Compare
mdimjasevic
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We went over it in a call.
elland
commented
Jul 29, 2024
@@ -124,9 +125,8 @@ migrations = | |||
V81_AddFederationRemoteTeams.migration, | |||
V82_DropPhoneColumn.migration, | |||
V83_AddTextStatus.migration, | |||
V84_DropTeamInvitationPhone.migration | |||
V84_DropTeamInvitationPhone.migration, | |||
V85_DropUserKeysHashed.migration | |||
-- FUTUREWORK: undo V41 (searchable flag); we stopped using it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fisx do we need to do anything here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d