Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Weed out dead code (part 2) #4173

Merged
merged 16 commits into from
Jul 29, 2024
Merged

[chore] Weed out dead code (part 2) #4173

merged 16 commits into from
Jul 29, 2024

Conversation

elland
Copy link
Contributor

@elland elland commented Jul 29, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 29, 2024
@elland elland changed the title Elland/weed2 [chore] Weed out dead code (part 2) Jul 29, 2024
@elland elland marked this pull request as ready for review July 29, 2024 09:53
@elland elland force-pushed the elland/weed2 branch 4 times, most recently from 59e8c83 to 395a8f2 Compare July 29, 2024 11:43
@mdimjasevic mdimjasevic self-requested a review July 29, 2024 13:11
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We went over it in a call.

@@ -124,9 +125,8 @@ migrations =
V81_AddFederationRemoteTeams.migration,
V82_DropPhoneColumn.migration,
V83_AddTextStatus.migration,
V84_DropTeamInvitationPhone.migration
V84_DropTeamInvitationPhone.migration,
V85_DropUserKeysHashed.migration
-- FUTUREWORK: undo V41 (searchable flag); we stopped using it in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fisx do we need to do anything here?

@elland elland merged commit 34bfff6 into develop Jul 29, 2024
9 checks passed
@elland elland deleted the elland/weed2 branch July 29, 2024 15:03
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants