Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inbucket: allow configuration of issuer #4031

Merged
merged 1 commit into from
Apr 30, 2024
Merged

inbucket: allow configuration of issuer #4031

merged 1 commit into from
Apr 30, 2024

Conversation

smatting
Copy link
Contributor

This PR updates the inbucket Helm chart.

For the certificate request:

  • Removes provisioning of an Issuer object
  • Requires the caller to provide a issuer via issuerRef

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 30, 2024
@smatting smatting requested a review from supersven April 30, 2024 15:07
@smatting smatting merged commit 68a6e98 into develop Apr 30, 2024
4 of 7 checks passed
@smatting smatting deleted the WPB-8876-inbucket-cert-issuers branch April 30, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastaab mastaab mastaab approved these changes

@supersven supersven Awaiting requested review from supersven

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @mastaab @zebot