Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[chore] use PathInfo consistently" [skip-ci] #4003

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Apr 16, 2024

@supersven this was actually no PathInfo, it just looked similar 👀

This reverts commit 71c8c59.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d n/a
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 16, 2024
@MangoIV MangoIV changed the title [skip-ci] Revert "[chore] use PathInfo consistently" Revert "[chore] use PathInfo consistently" [skip-ci] Apr 16, 2024
@MangoIV MangoIV requested a review from supersven April 16, 2024 12:31
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MangoIV MangoIV merged commit 1f239ae into develop Apr 16, 2024
8 checks passed
@MangoIV MangoIV deleted the mangoiv/fix-erroneous-fix branch April 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants