Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-ephemeral: Provide password as value #3994

Merged

Conversation

supersven
Copy link
Contributor

This way we can use different passwords on our test systems. Ensuring that the password is really configurable (and not accidentally hardcoded somewhere.)

Ticket: https://wearezeta.atlassian.net/browse/WPB-7283

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

This way we can use different passwords on our test systems. Ensuring
that the password is really configurable (and not accidentally hardcoded
somewhere.)
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 11, 2024
@supersven supersven marked this pull request as ready for review April 12, 2024 10:24
@supersven supersven merged commit e4fa0f1 into develop Apr 12, 2024
8 checks passed
@supersven supersven deleted the sventennie/elasticsearch-ephemeral-password-as-value branch April 12, 2024 10:24
fisx pushed a commit that referenced this pull request Apr 15, 2024
This way we can use different passwords on our test systems. Ensuring
that the password is really configurable (and not accidentally hardcoded
somewhere.)
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants