Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove geoDb option from Brig #3975

Merged
merged 1 commit into from
Apr 4, 2024
Merged

remove geoDb option from Brig #3975

merged 1 commit into from
Apr 4, 2024

Conversation

stefanwire
Copy link
Contributor

@stefanwire stefanwire commented Mar 27, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-5972

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 27, 2024
@stefanwire stefanwire marked this pull request as ready for review March 28, 2024 08:15
@supersven supersven self-requested a review April 4, 2024 14:10
mdimjasevic
mdimjasevic approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, recently you worked on removing the actual code using this. Can you link the PR and/or a JIRA ticket for the context?

supersven
supersven approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanwire stefanwire merged commit 8338956 into develop Apr 4, 2024
8 checks passed
@stefanwire stefanwire deleted the sb/geodb branch April 4, 2024 14:20
fisx pushed a commit that referenced this pull request Apr 15, 2024
@stefanwire @fisx
remove geoDb option from Brig (#3975)
9fb07ba
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanwire @supersven @mdimjasevic @zebot